-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Fleet setup styles #78
Conversation
…description for each section of the form for now.
placeholder="Password" | ||
type="password" | ||
tabIndex={tabIndex} | ||
hint={['Must include 7 characters, at least 1 number (e.g. 0 - 9), and at least 1 symbol (e.g. &*#)']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is definitely helpful.
@@ -49,11 +49,11 @@ class OrgDetails extends Component { | |||
{...fields.org_logo_url} | |||
placeholder="Organization Logo URL (optional)" | |||
tabIndex={tabIndex} | |||
hint="must start with https://" | |||
hint="Set a logo to use in the Fleet application. Should be an https URL to an image file (e.g. https://fleetdm.com/logo.png)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely more helpful. Do you know the dimensions we expect for this?
Could we easily make https://fleetdm.com/logo.png actually serve an asset that would fit will there (in case anyone looks at it as an example)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noahtalerman @edamamedesign how about we specify the ideal px dimensions for the image in the help text? Even though there is wiggle room with the exact pixels, some guidance helps
@zwass good call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/fleetdm/fleetdm.com/pull/10 makes an example image available at https://fleetdm.com/logo.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noahtalerman@aaee5d2 tweaks the verbiage to add a recommendation about dimensions+aspect ratio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great call Zach. The verbiage change looks good. Thanks Mike!
This PR is part of the UI Refresh #38.
The goal of this PR is to update the styles of the Fleet setup (onboarding) flow.
AdminDetails
,OrgDetails
,KolideDetails
, andConfirmationPage
components. This allows the entire container for each of these components to move and replace the previous component when the user completes a portion of the flow. Prior to these changes, only the individual components would move while their shared parent container remained stationary.Demo
fleet-setup.mov.zip