Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fleet setup styles #78

Merged
merged 7 commits into from
Dec 2, 2020

Conversation

noahtalerman
Copy link
Member

@noahtalerman noahtalerman commented Dec 1, 2020

This PR is part of the UI Refresh #38.

The goal of this PR is to update the styles of the Fleet setup (onboarding) flow.

  • Add container, header, and description to each of the AdminDetails , OrgDetails , KolideDetails, and ConfirmationPage components. This allows the entire container for each of these components to move and replace the previous component when the user completes a portion of the flow. Prior to these changes, only the individual components would move while their shared parent container remained stationary.

localhost_8080_setup (1)
localhost_8080_setup (2)
localhost_8080_setup (3)
localhost_8080_setup (4)

Demo
fleet-setup.mov.zip

placeholder="Password"
type="password"
tabIndex={tabIndex}
hint={['Must include 7 characters, at least 1 number (e.g. 0 - 9), and at least 1 symbol (e.g. &*#)']}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this is definitely helpful.

@@ -49,11 +49,11 @@ class OrgDetails extends Component {
{...fields.org_logo_url}
placeholder="Organization Logo URL (optional)"
tabIndex={tabIndex}
hint="must start with https://"
hint="Set a logo to use in the Fleet application. Should be an https URL to an image file (e.g. https://fleetdm.com/logo.png)."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely more helpful. Do you know the dimensions we expect for this?

Could we easily make https://fleetdm.com/logo.png actually serve an asset that would fit will there (in case anyone looks at it as an example)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noahtalerman @edamamedesign how about we specify the ideal px dimensions for the image in the help text? Even though there is wiggle room with the exact pixels, some guidance helps

@zwass good call

Copy link
Member

@mikermcneil mikermcneil Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/fleetdm/fleetdm.com/pull/10 makes an example image available at https://fleetdm.com/logo.png

Copy link
Member

@mikermcneil mikermcneil Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noahtalerman@aaee5d2 tweaks the verbiage to add a recommendation about dimensions+aspect ratio

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great call Zach. The verbiage change looks good. Thanks Mike!

@noahtalerman noahtalerman merged commit 7d9906e into fleetdm:master Dec 2, 2020
@noahtalerman noahtalerman deleted the update-setup-styles branch December 2, 2020 14:59
getvictor added a commit that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants