Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splash-test.py #165

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update splash-test.py #165

wants to merge 1 commit into from

Conversation

non-npc
Copy link
Contributor

@non-npc non-npc commented Sep 12, 2024

The "splash" property has been deprecated in recent versions of Flet. This patch updates the code to address this issue.

The "splash" property has been deprecated in recent versions of Flet. This patch updates the code to address this issue.
@ndonkoHenri
Copy link
Contributor

Wouldn't it be nice to store the bar in a variable, then use page.overlay.remove(my_bar) to remove it?
What do you think?

@non-npc
Copy link
Contributor Author

non-npc commented Sep 12, 2024

store the bar in a variable, then use page.overlay.remove(my_bar) to remove it

absolutely, fantastic idea!

Here is the updated code, let me know if you approve and I will apply the changes.

`from time import sleep
import flet
from flet import ElevatedButton, ProgressBar

def main(page):
def button_click(e):
my_bar = ProgressBar()
page.overlay.append(my_bar)

    btn.disabled = True
    page.update()
    sleep(3)

    page.overlay.remove(my_bar)
    btn.disabled = False
    page.update()

btn = ElevatedButton("Do some lengthy task!", on_click=button_click)
page.add(btn)

flet.app(target=main)
`

@ndonkoHenri
Copy link
Contributor

Looks good to me.

non-npc added a commit to non-npc/examples that referenced this pull request Sep 12, 2024
The "splash" property has been deprecated in recent versions of Flet. This patch updates the code to address this issue.

Additionally as per request (flet-dev#165 (comment))  the bar is now stored in a variable, and we use page.overlay.remove(my_bar) to remove it
@non-npc non-npc mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants