Hip Refactor for optimizer, partition and pool #1379
Conversation
There was a problem hiding this comment.
Done:)
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @reyna-abhyankar)
lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):
Previously, reyna-abhyankar (Reyna Abhyankar) wrote…
Why?
I see. I changed INCLUDE to EXCLUDE in the macro. Thanks for pointing out.
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @Bob-Chen222)
lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):
Previously, Bob-Chen222 (Bob Chen) wrote…
I see. I changed INCLUDE to EXCLUDE in the macro. Thanks for pointing out.
What do you mean? Isn't the API itself supposed to be miopenPoolingAverage?
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @reyna-abhyankar)
lib/kernels/src/hip/pool_2d_kernels.cpp line 59 at r1 (raw file):
Previously, reyna-abhyankar (Reyna Abhyankar) wrote…
What do you mean? Isn't the API itself supposed to be
miopenPoolingAverage?
Got it. It has now reverted to the previous version. I trusted GPT too much...
lib/kernels/src/hip/optimizer_kernel.cpp line 0 at r1 (raw file):
Previously, reyna-abhyankar (Reyna Abhyankar) wrote…
Don't worry about the optimizer kernels. We haven't properly refactored the cuda file
Done.
Description of changes:
add optimizer, partition, pool hip refactor
Related Issues:
Linked Issues:
Issues closed by this PR:
This change is