10 update to use pydantic v2 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfse-slafleur
changed the base branch from
main
to
38-update-s2-definitions-to-002-beta
lfse-slafleur
commented
Jul 29, 2024
| @@ -10,7 +10,7 @@ ignore-paths=src/s2python/generated/ | |||
| # avoid hangs. | |||
| jobs=1 | |||
|
|
|||
| disable=missing-class-docstring,missing-module-docstring,too-few-public-methods,missing-function-docstring | |||
| disable=missing-class-docstring,missing-module-docstring,too-few-public-methods,missing-function-docstring,no-member | |||
There was a problem hiding this comment.
pylint is not smart enough to follow protocols like mypy. Mypy should cover all no-member issues so disable in pylint.
|
Had to start the pipeline manually due to inactivity. Result may be found here: https://github.com/flexiblepower/s2-python/actions/runs/10147264724 |
Base automatically changed from
38-update-s2-definitions-to-002-beta
to
main
September 6, 2024 08:23
|
Bypass due to #44 |
|
Seita mentioned they may have need for a pydantic v1 version. So branch here: https://github.com/flexiblepower/s2-python/tree/pydantic_v1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #39