Fix ID validation #42
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mat while the S2 spec is less restrictin (strings composed by alphanmeric, dashes, underscores and semicolons with a range between 2 and 64). Signed-off-by: Victor Garcia Reolid <[email protected]>
@Flix6x While you are absolutely right that the JSON schema and Asyncapi specify a range between 2-64, it might be good we check this with the maintainers of s2-ws-json first if it isn't a bug. The description of the specifications state that a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the ID was restricted to follow a UUID format while the S2 spec is less restrictive (strings composed by alphanumeric, dashes, underscores and semicolons with a range between 2 and 64).