Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for v0.2.0.dev2 release based on Pydantic v1 #56

Merged
merged 15 commits into from
Dec 7, 2024

Conversation

Flix6x
Copy link
Collaborator

@Flix6x Flix6x commented Dec 5, 2024

@lfse-slafleur I've been getting help from @victorgarcia98 today. We have solved our issues with Pydantic 1, in a way where we mostly touched the non-generated classes (apart from the ID). This PR now unfortunately combines the UUID PR and the Literal PR. For sake of effort, would you be generally okay if we would take responsibility for maintaining releases based on the pydantic-v1 branch? For now we'd keep doing dev releases only (0.2.0.devX).

@VladIftime will be working on integrating more control types in the next 6 months, but we need it to run on Pydantic v1 until Home Assistant supports Pydantic v2 (which will happen, but we have no control over its pace).

victorgarcia98 and others added 8 commits March 21, 2024 10:46
Signed-off-by: Victor Garcia Reolid <[email protected]>
# Conflicts:
#	src/s2python/generated/gen_s2.py
…ut-file-type openapi --output src/s2python/generated/gen_s2.py`

Signed-off-by: F.N. Claessen <[email protected]>
…mat while the S2 spec is less restrictin (strings composed by alphanmeric, dashes, underscores and semicolons with a range between 2 and 64).

Signed-off-by: Victor Garcia Reolid <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
Signed-off-by: F.N. Claessen <[email protected]>
@Flix6x Flix6x self-assigned this Dec 5, 2024
@lfse-slafleur
Copy link
Member

@lfse-slafleur I've been getting help from @victorgarcia98 today. We have solved our issues with Pydantic 1, in a way where we mostly touched the non-generated classes (apart from the ID). This PR now unfortunately combines the UUID PR and the Literal PR. For sake of effort, would you be generally okay if we would take responsibility for maintaining releases based on the pydantic-v1 branch? For now we'd keep doing dev releases only (0.2.0.devX).

@VladIftime will be working on integrating more control types in the next 6 months, but we need it to run on Pydantic v1 until Home Assistant supports Pydantic v2 (which will happen, but we no control over it's pace).

Hi @Flix6x ! Yep, that makes a lot of sense for you to have control over the v1 pydantic distributions. Feel free to use the v0.1.X versionspace for pydantic v1 if you would like to have 'proper' releases instead of just dev releases. Also, if you have any changes that main might benefit from, feel free to tag me as a reviewer. Also, if you need any more input from my side, feel free to let me know.

@Flix6x Flix6x marked this pull request as ready for review December 7, 2024 18:43
@Flix6x Flix6x merged commit 4302c85 into pydantic_v1 Dec 7, 2024
38 checks passed
@Flix6x Flix6x deleted the pydantic_v1-test-resolving-conflicts branch December 7, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants