Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'VS Code' page #104

Closed
wants to merge 4 commits into from
Closed

Conversation

sockmaster27
Copy link
Contributor

Fixes #103

@sockmaster27
Copy link
Contributor Author

sockmaster27 commented Aug 7, 2023

It looks kind of empty. I'll have to confess that I'm not great at copy writing.

image

@magnus-madsen
Copy link
Member

  • Lets try the webp format and see how the file sizes are.
  • Let's fix a specific resolution (so all videos are the same size and fonts appear the same size).
  • In the examples, lets try to avoid showing "hanging" { or other code that is not relevant. For example, the ToString derivation shows a lot of code, but most of it is not relevant.
  • Dont worry about copy-editing, if you just write some initial text, I can help improve it.

Let focus on getting these three videos ready and then we can work on the next.

@magnus-madsen
Copy link
Member

  • Experiment with light theme?

@magnus-madsen
Copy link
Member

@sockmaster27
Copy link
Contributor Author

Webp is locked to a very low framerate so it's hard to compare, but the one I did was about 60KB vs the mp4's (60fps) 100~200KB, so I wouldn't say it's an important difference.

@magnus-madsen
Copy link
Member

Here is a 30FPS webp file: https://flix.dev/test01.webp which requires only 27KB.

This is 10x less than the mp4 file, so I am definitely convinced we should go with that.

Just drop OBS and use ScreenToGif with ffmpeg.

@sockmaster27
Copy link
Contributor Author

Here is a 30FPS webp file: https://flix.dev/test01.webp which requires only 27KB

I thought the cap was lower, and to be fair that one is also less than a quarter of the resolution of the others, but I agree.

@sockmaster27
Copy link
Contributor Author

Here's how it looks now:
image

@sockmaster27
Copy link
Contributor Author

It's pretty busy-looking with everything moving at once.
Maybe they should only play on hover?

@sockmaster27
Copy link
Contributor Author

image

@magnus-madsen
Copy link
Member

What do you think about using a light theme?

@magnus-madsen
Copy link
Member

It's pretty busy-looking with everything moving at once. Maybe they should only play on hover?

People might not know to hover, but I understand the issue.

@sockmaster27
Copy link
Contributor Author

What do you think about using a light theme?

I can definitely try it out, but I'd think the dark is more recognizable as VS Code.

@sockmaster27
Copy link
Contributor Author

It's pretty busy-looking with everything moving at once. Maybe they should only play on hover?

People might not know to hover, but I understand the issue.

Perhaps show an overlayed play button?

@magnus-madsen
Copy link
Member

Perhaps show an overlayed play button?

Lets keep the outplay for now

@magnus-madsen
Copy link
Member

What do you think about using a light theme?

Instead, what if we make this page black instead of white (by black I mean the same background as VSCode).

@magnus-madsen
Copy link
Member

The text would have to be white.

@sockmaster27
Copy link
Contributor Author

Could work, I'll try it

@magnus-madsen
Copy link
Member

I think some more vertical space would also be useful.

@sockmaster27
Copy link
Contributor Author

Instead, what if we make this page black instead of white (by black I mean the same background as VSCode).

Unfortunately, this doesn't really appear to be possible within the current framework, since all pages share the same background.

@sockmaster27
Copy link
Contributor Author

With added spacing:

image

@magnus-madsen
Copy link
Member

Hmm. I still think it looks jarring. But if you insist, surely we can have some black box around that part of the page?

@magnus-madsen
Copy link
Member

Like, just put everything below the horizontal ruler in black box.

@magnus-madsen
Copy link
Member

What's the status on this?

@sockmaster27
Copy link
Contributor Author

What's the status on this?

Annoying 😞 procrastinating

@sockmaster27
Copy link
Contributor Author

I think I'll try light mode though

@magnus-madsen
Copy link
Member

Fixed in master.

@sockmaster27 sockmaster27 deleted the vscode-page branch December 30, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add page with Visual Studio Code Gifs
2 participants