chore: swap out node-fetch-commonjs with node-fetch (#329)

client/package.json

@@ -14,7 +14,7 @@
   },
   "dependencies": {
     "lodash": "^4.17.21",
-    "node-fetch-commonjs": "^3.2.4",
+    "node-fetch": "^3.3.2",
     "vscode-languageclient": "^8.0.1"
   },
   "devDependencies": {

client/src/services/releases.ts

@@ -2,8 +2,6 @@
 // https://github.com/rust-analyzer/rust-analyzer/blob/master/editors/code/src/net.ts
 // The code in rust-analyzer is released under the same licence as this project.
 
-// Replace with `import fetch from "node-fetch"` once this is fixed in rollup:
-// https://github.com/rollup/plugins/issues/491
 import * as vscode from 'vscode'
 import * as stream from 'stream'
 import * as crypto from 'crypto'
@@ -13,7 +11,9 @@ import * as util from 'util'
 import * as path from 'path'
 import { strict as nativeAssert } from 'assert'
 import * as _ from 'lodash'
-const fetch = require('node-fetch-commonjs')
+
+// Remove when support for Node.js 20 is dropped
+import fetch from 'node-fetch'
 
 const pipeline = util.promisify(stream.pipeline)
 
@@ -61,8 +61,8 @@ export async function fetchRelease(
     throw new Error(`Got response ${response.status} when trying to fetch ` + `release info for ${releaseTag} release`)
   }
 
-  // We skip runtime type checks for simplicity (here we cast from `any` to `GithubRelease`)
-  const release: GithubRelease = await response.json()
+  // We skip runtime type checks for simplicity (here we cast from `unknown` to `GithubRelease`)
+  const release = (await response.json()) as GithubRelease
   const flixRelease: FlixRelease = {
     url: _.get(release, 'url'),
     id: _.get(release, 'id'),