-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: launch REPL as own shell #374
Conversation
Sorry for the large diff. |
OK. I take a look. |
How can it work without shell quote? Can you try to create an absurd path and open it in VSCode? (E.g. a path with lots of spaces and special chars and quotes) |
What happens if you:
Does it open a new terminal as hoped? |
Where does the exit code I assume if you type |
My guess would be that it isn't necessary if the process is started directly without going through a shell: |
Yes |
Ok, so it would seem that "it works well"? |
In addition, can you try two things:
|
That exit code seems to be mean that the process has been 'forced' to quit via Ctrl+C. |
But what happens with |
|
It just quits the shell gracefully and hides the panel. |
Other than the ugly error reporting, yes. |
Fixes #372