Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: highlight function- and struct arrow differently #443

Merged
merged 1 commit into from
Nov 9, 2024
Merged

feat: highlight function- and struct arrow differently #443

merged 1 commit into from
Nov 9, 2024

Conversation

sockmaster27
Copy link
Contributor

Fixes #442

@sockmaster27 sockmaster27 marked this pull request as ready for review September 6, 2024 14:18
@sockmaster27
Copy link
Contributor Author

@magnus-madsen
ping

@magnus-madsen
Copy link
Member

Wait, I thought we could not fix this. What does this do? Do you have a screenshot?

@sockmaster27
Copy link
Contributor Author

Same status as in #442 (comment)
Optimal solution IMO: Fix in Flixify theme
Secondary solution: Do not categorize struct arrow as anything

@sockmaster27
Copy link
Contributor Author

@magnus-madsen
Can we merge this? It's strictly an improvement IMO. We can always fix Flixify at a later point.

@magnus-madsen
Copy link
Member

Do you have a screenshot with the flixify theme?

@sockmaster27
Copy link
Contributor Author

It's unchanged:
363305804-590b59d0-5b2a-4978-bfcb-c50e8617f0b4

@magnus-madsen magnus-madsen merged commit bdfc3e2 into flix:master Nov 9, 2024
6 checks passed
@sockmaster27 sockmaster27 deleted the arrow branch November 9, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magnus-madsen magnus-madsen magnus-madsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arrow color when no space
2 participants
@sockmaster27 @magnus-madsen