Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reflect language changes #460

Merged
merged 4 commits into from
Nov 22, 2024
Merged

test: reflect language changes #460

merged 4 commits into from
Nov 22, 2024

Conversation

sockmaster27
Copy link
Contributor

@sockmaster27 sockmaster27 commented Nov 21, 2024

Related to flix/flix#9236

@sockmaster27
Copy link
Contributor Author

A change has been made which causes the highlighted range of an enum case to go from

enum Shape {
    case Circle(Int32),
         ^^^^^^
    case Square(Int32),
    case Rectangle(Int32, Int32)
}

to

enum Shape {
    case Circle(Int32),
         ^^^^^^^^^^^^^
    case Square(Int32),
    case Rectangle(Int32, Int32)
}

However, this seems to be changed by vscode before being displayed:
image

@sockmaster27
Copy link
Contributor Author

The failing CI run seems to not include the most recent commit. Weird. Can we try retriggering it?

@magnus-madsen
Copy link
Member

I retriggered CI

@magnus-madsen
Copy link
Member

@LoZander @sockmaster27 In terms of highlighting. What do you think makes the most sense?

This reverts commit 2d5a479.
@magnus-madsen
Copy link
Member

Tests still fail. Its strange.

@sockmaster27
Copy link
Contributor Author

No clue. Could it be an error on GitHub's end?

@magnus-madsen
Copy link
Member

No clue. Could it be an error on GitHub's end?

It seems unlikely. Its probably a bug in our code. Maybe insert a lot of prints?

@sockmaster27
Copy link
Contributor Author

I got the same error when running the tests before the second commit, but now it passes for me.
What the CI reports as the expected value no longer appears anywhere in our code.

@magnus-madsen
Copy link
Member

I got the same error when running the tests before the second commit, but now it passes for me. What the CI reports as the expected value no longer appears anywhere in our code.

😮

@magnus-madsen
Copy link
Member

I could try to merge the PR and see what happens?

@sockmaster27
Copy link
Contributor Author

Might as well try.

@magnus-madsen magnus-madsen merged commit 3232287 into flix:master Nov 22, 2024
4 of 6 checks passed
@magnus-madsen
Copy link
Member

I tried, so now I suppose we need another fake PR to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants