sokol_nuklear.h: enable setting mouse cursor

[zeozeozeo]

Add an option enable_set_mouse_cursor to enable setting OS mouse cursors with sapp_set_mouse_cursor. By default Nuklear draws its' own custom cursor.

It is the opposite of disable_set_mouse_cursor in sokol_imgui.h, to not break existing apps.

Currently this option doesn't actually disable loading the custom cursor icons, and still requires you to call nk_style_hide_cursor() to hide Nuklear's cursor.

[floooh]

Interesting, I never saw for (enum ... :)

I'll let the CI complete and if everything is green I'll merge the PR (and will probably also update one of the sokol-samples to enable mouse cursors).

[floooh]

Btw, I seem to remember that there was a specific reason that I'm initializing the mouse cursor before the switch with the currently active mouse cursor instead of SAPP_MOUSECURSOR_ARROW, I just don't remember what that specific situation was:

sokol/util/sokol_imgui.h

Line 3007 in 7e50f80

sapp_mouse_cursor cursor = sapp_get_mouse_cursor();

(if your code somehow triggers that problem then we can still fix it in a separate PR I guess)

[floooh]

Hmm, somehow I hadn't noticed that the Nuklear software mouse cursor is now always active... that definitely wasn't intended... (meaning that the Nuklear mouse cursor is always active since this PR was merged: #1138)

[zeozeozeo]

Hmm, somehow I hadn't noticed that the Nuklear software mouse cursor is now always active... that definitely wasn't intended...

Yeah, apparently nk_style_load_all_cursors() will always enable the software cursor. Maybe this option should be changed to disable_set_mouse_cursor, and disable loading cursors when it is not enabled?

[floooh]

I think I will just modify your code to work the same as sokol_imgui.h: rename the flag to disable... and by default use the sokol_app.h mouse cursor functions, and otherwise use the Nuklear builtin mouse cursors.

PS: I will add two flags: disable_set_mouse_cursor (which works the same as sokol_imgui.h) and enable_software_mouse_cursor (which loads the software mouse cursor images).

[floooh]

Hmm ok, not so simple, looks like calling nk_style_load_all_cursors() is what activates the cursor handling in the first place.

[floooh]

...I think I'll go with your original code :)

[floooh]

Ok, one change I'll do after playing around with it: I'll move the code from the event handler to the start of the snk_render() function. Otherwise the mouse pointer gets stuck at the end of an operation until it is moved again.

[floooh]

Ooof I broke it :D (forgot about the SOKOL_NUKLEAR_NO_SOKOL_APP define, will fix that on main)

[floooh]

Ok, all green now. Thanks for the PR!

[floooh]

Ok, the two nuklear sokol-samples now use your code:

• https://floooh.github.io/sokol-html5/nuklear-sapp.html
• https://floooh.github.io/sokol-html5/nuklear-images-sapp.html

[zeozeozeo]

nice