Add deprecated: argument to attribute definition (closes #81)

lib/hcloud/resource.rb

@@ -30,6 +30,16 @@ def ==(other)
       id && id == other.id
     end
 
+    def self.attribute(name, *args, deprecated: false, **kwargs)
+      super(name, *args, **kwargs)
+
+      define_method(name) do |**params|
+        warn "[DEPRECATION] Field \"#{name}\" on #{self.class.name} is deprecated." if deprecated
+
+        super(**params)
+      end
+    end
+
     def self.resource_name
       name.demodulize.underscore
     end

lib/hcloud/resources/pricing.rb

@@ -27,18 +27,10 @@ class Pricing < Resource
 
     attribute :server_types, :server_type_price, array: true, default: -> { [] }
 
-    attribute :traffic, :traffic_price
+    attribute :traffic, :traffic_price, deprecated: true
 
     attribute :vat_rate
 
     attribute :volume, :volume_price
-
-    def traffic
-      # FIXME: Attribute will return null on 2024-08-05
-      # FIXME: Attribute will be removed on 2024-11-05
-      warn "[DEPRECATION] Field \"traffic\" on pricing is deprecated."
-
-      super
-    end
   end
 end

lib/hcloud/resources/server_type.rb

@@ -30,29 +30,19 @@ class ServerType < Resource
     attribute :cores, :integer
     attribute :disk, :integer
     attribute :memory, :integer
-    attribute :included_traffic, :integer
+
+    # FIXME: Attribute will return null on 2024-08-05
+    # FIXME: Attribute will be removed on 2024-11-05
+    attribute :included_traffic, :integer, deprecated: true
 
     attribute :cpu_type
     attribute :storage_type
 
     attribute :prices, :price, array: true, default: -> { [] }
 
-    attribute :deprecated, :boolean
     attribute :deprecation, :deprecation
 
-    def included_traffic
-      # FIXME: Attribute will return null on 2024-08-05
-      # FIXME: Attribute will be removed on 2024-11-05
-      warn "[DEPRECATION] Field \"included_traffic\" on server types is deprecated."
-
-      super
-    end
-
-    def deprecated
-      warn "[DEPRECATION] Field \"deprecated\" on server types is deprecated."
-
-      super
-    end
+    attribute :deprecated, :boolean, deprecated: true
 
     alias deprecated? deprecated
   end

spec/hcloud/resource_spec.rb

@@ -13,6 +13,10 @@
     expect(resource.foo).to eq "bar"
   end
 
+  it "allows deprecated attributes" do
+    expect { resource.deprecated }.to output("[DEPRECATION] Field \"deprecated\" on ExampleResource is deprecated.\n").to_stderr
+  end
+
   describe "#to_h" do
     it "serializes the identifier" do
       expect(resource.to_h).to eq({ id: resource.id })

spec/support/helpers/resource.rb

@@ -31,6 +31,8 @@ class ExampleResource < HCloud::Resource
 
   attribute :sibling, :sibling
 
+  attribute :deprecated, deprecated: true
+
   attribute :labels, default: -> { {} }
 
   action :resize