Skip to content

Commit

Permalink
Fix/get prod modules param (#42)
Browse files Browse the repository at this point in the history
* docs(scully-plugin-angular-delay): added docs for angular delay plugin

* chore(core): add projects to commitizen

* fix(nx-serverless): fix getProdModules parameters to be correct when calling itself

Co-authored-by: wickstargazer <[email protected]>
  • Loading branch information
wickstargazer and wickstargazer authored Aug 3, 2020
1 parent 368ad01 commit 150c7bf
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 14 deletions.
9 changes: 4 additions & 5 deletions .cz-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ module.exports = {
{ name: 'docs', description: 'anything related to docs infrastructure' },
{ name: 'nx-aws-cdk', description: 'anything aws-cdk specific' },
{ name: 'angular', description: 'anything angular specific' },
{ name: 'scully-plugin-angular-delay', description: 'anything scully-plugin-angular-delay specific' },
{ name: 'scully-plugin-google-analytics', description: 'anything scully-plugin-google-analytics specific' },
{ name: 'scully-plugin-lazy-load-picture-tag', description: 'anything scully-plugin-lazy-load-picture-tag specific' },
{ name: 'node', description: 'anything Node specific' },
{ name: 'linter', description: 'anything Linter specific' },
{
Expand All @@ -32,11 +35,7 @@ module.exports = {
name: 'repo',
description: 'anything related to managing the repo itself'
},
{ name: 'misc', description: 'misc stuff' },
{
name: 'scully-plugin-angular-delay',
description: 'anything related to Scully plugin for delaying Angular'
}
{ name: 'misc', description: 'misc stuff' }
],

allowTicketNumber: true,
Expand Down
2 changes: 1 addition & 1 deletion libs/nx-serverless/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flowaccount/nx-serverless",
"version": "0.5.0",
"version": "0.5.1",
"main": "src/index.js",
"description": "Serverless schematics for nx workspace",
"keywords": [
Expand Down
4 changes: 2 additions & 2 deletions libs/nx-serverless/src/utils/normalize.ts
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,8 @@ export function getProdModules(
_.map(peerDependencies, (value, key) => ({ external: key })),
packageJson,
packagePath,
dependencyGraph,
forceExcludes
forceExcludes,
dependencyGraph
);
Array.prototype.push.apply(prodModules, peerModules);
}
Expand Down
2 changes: 1 addition & 1 deletion libs/scully-plugin-angular-delay/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@flowaccount/scully-plugin-angular-delay",
"version": "0.0.6",
"version": "0.0.9",
"peerDependencies": {
"@scullyio/scully": "^0.0.91"
},
Expand Down
4 changes: 2 additions & 2 deletions libs/scully-plugin-google-analytics/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,13 @@
To install this library with `npm` run

```bash
npm install scully-plugin-google-analytics --save-dev
npm install @flowaccount/scully-plugin-google-analytics --save-dev
```

or with `yarn`

```bash
yarn add scully-plugin-google-analytics --dev
yarn add @flowaccount/scully-plugin-google-analytics --dev
```

## Usage
Expand Down
4 changes: 2 additions & 2 deletions libs/scully-plugin-lazy-load-picture-tag/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ Read more about the experiment at this article --> [Angular Paperclip Experiment
To install this library with `npm` run

```bash
npm install scully-plugin-lazy-load-picture-tag --save-dev
npm install @flowaccount/scully-plugin-lazy-load-picture-tag --save-dev
```

or with `yarn`

```bash
yarn add scully-plugin-lazy-load-picture-tag --dev
yarn add @flowaccount/scully-plugin-lazy-load-picture-tag --dev
```

## Usage
Expand Down
2 changes: 1 addition & 1 deletion scripts/commit-lint.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const gitMessage = require('child_process')
.toString()
.trim();

const matchCommit = /(chore|feat|fix|cleanup|docs)\((nx-serverless|core|docs|nx-aws-cdk|lint|angular|node|testing|repo|misc|scully-plugin-angular-delay)\):\s(([a-z0-9:\-\s])+)/g.test(
const matchCommit = /(chore|feat|fix|cleanup|docs)\((nx-serverless|core|docs|nx-aws-cdk|lint|angular|scully-plugin-angular-delay|scully-plugin-google-analytics|scully-plugin-lazy-load-picture-tag|node|testing|repo|misc)\):\s(([a-z0-9:\-\s])+)/g.test(
gitMessage
);
const matchRevert = /Revert/gi.test(gitMessage);
Expand Down

0 comments on commit 150c7bf

Please sign in to comment.