Skip to content

Commit

Permalink
fix: upgrade esbuild-node-externals and mock-fs deps
Browse files Browse the repository at this point in the history
  • Loading branch information
floydspace committed Sep 26, 2024
1 parent c32aa53 commit 0b177aa
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 24 deletions.
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -85,13 +85,13 @@
"@types/serverless": "^3.12.14",
"all-contributors-cli": "^6.24.0",
"esbuild": "^0.24.0",
"esbuild-node-externals": "^1.14.0",
"esbuild-node-externals": "^1.15.0",
"eslint": "^8.56.0",
"extract-zip": "^2.0.1",
"husky": "^8.0.2",
"jest": "^29.3.1",
"lint-staged": "^13.1.0",
"mock-fs": "^5.2.0",
"mock-fs": "^5.3.0",
"mock-spawn": "^0.2.6",
"prettier": "^2.8.1",
"semantic-release": "^19.0.5",
Expand All @@ -111,7 +111,6 @@
"node": ">=18.0.0"
},
"overrides": {
"esbuild": "$esbuild",
"eslint": "$eslint"
}
}
7 changes: 1 addition & 6 deletions src/tests/util.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// eslint-disable-next-line eslint-comments/disable-enable-pair
/* eslint-disable jest/no-standalone-expect */
import fs from 'fs-extra';
import mockFs from 'mock-fs';
import path from 'path';
Expand All @@ -19,9 +17,6 @@ describe('utils/findProjectRoot', () => {
});
});

const nodeVersion = parseInt(process.versions.node.split('.')[0]!, 10);
const itNode18 = nodeVersion > 18 ? it.skip : it;

describe('utils/zip', () => {
const mtime = new Date(2024, 0, 1, 0, 0, 0, 0);

Expand Down Expand Up @@ -67,7 +62,7 @@ describe('utils/zip', () => {
await expect(zip(zipPath, filesPathList)).rejects.toThrow("ENOENT, no such file or directory '/src/incorrect.txt'");
});

itNode18.each([{ useNativeZip: true }, { useNativeZip: false }])(
it.each([{ useNativeZip: true }, { useNativeZip: false }])(
'should properly archive files when useNativeZip=$useNativeZip.',
async ({ useNativeZip }) => {
const source = '/src';
Expand Down

0 comments on commit 0b177aa

Please sign in to comment.