Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration/kusto: add basic integration test for kusto output plugin #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

papigers
Copy link

@papigers papigers commented Jul 6, 2022

Integration test for the new Kusto output plugin (fluent/fluent-bit#5645).

The deployment uses this reverse proxy I created that authenticates using microsoft's authentication library https://github.com/papigers/msal-proxy (only to not implement whole authentication flow in Bash, hope that's fine).

Before merging, an azure cluster needs to be created and pre-configured (database, ingestion mapping, etc...)

@patrick-stephens
Copy link
Collaborator

Thanks for this @papigers , looks good to me. Only thing I'd say is can you add a license to the dependency you created just so we're covered?

@patrick-stephens
Copy link
Collaborator

@niedbalski only issue I can really see is handling runs without the new plugin, for the mainline branch and any PRs based on it currently.

@papigers
Copy link
Author

papigers commented Jul 6, 2022

@patrick-stephens added license now

@patrick-stephens
Copy link
Collaborator

Ah, that issue with packer is down to coming from a fork so can be ignored here.

@niedbalski niedbalski added the ok-to-test Run PR integration tests label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Run PR integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants