prohibit fluent logger to chocke on its own log messages in case of failure #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd messages it will choke on its own failure messages (cannot send message) ->this change breaks this circle by only logging the failure to send messages once per minute
|
@danischroeter afc9e84 mitigates the issue? |
|
@komamitsu sorry was off... |
komamitsu
reviewed
Sep 24, 2016
| @@ -179,6 +179,14 @@ private synchronized boolean send(byte[] bytes) { | |||
| return true; | |||
| } | |||
|
|
|||
| private void logCannotSendMaxOncePerMinute() { | |||
| // to not choke on our own log message | |||
| if(System.currentTimeMillis() + 60 * 1000 > lastCannotSendLogTimestamp) { | |||
There was a problem hiding this comment.
The suppression time 60 seconds seems too long to me. Could you make this value configurable (default: 10 seconds)?
|
I see. Can I ask you to resolve the merge conflict and address this comment https://github.com/fluent/fluent-logger-java/pull/59/files#r80361139 ? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the fluent logger is used as a logger for slf4j and it fails to send messages it will choke on its own failure messages (cannot send message) once the connection to fluentd is broken
->this change breaks this circle by only logging the failure to send messages max once per minute