Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing the use of custom Queue implementation for message event mode #174

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Farenheith
Copy link

Motivation

As array.shift needs to reindex the whole array for each execution, this can be pretty processing expensive if you need to do it in a high frequency.
Though a custom Queue implementation will loose to native array shift in cases where there is not much items to deal with, the difference of time in this cases seems to be irrelevant.
So, it is worth it to use a custom Queue implementation to have a faster and less cpu demanding shift processing.

There is a lot of Queue implementations out there, I just choose one of them with a simple implementation and more array like for this PR.

Thiago Santos added 2 commits June 25, 2020 10:31
Signed-off-by: Thiago Santos <[email protected]>
@Farenheith
Copy link
Author

Farenheith commented Jun 25, 2020

I changed the package version of mocha from "*" to "^6.0.0" because last versions of mocha doesn't supports v8.x and v10.x of node, so, the configured pipeline would not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant