Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deb rpm: add helper script to generate install script #679

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Sep 24, 2024

Currently, fluent-package install script is hosted on
https://toolbelt.treasuredata.com and maintained under private
repository.

It rely on deploying commercial cloud service and if we lost access to
that private repository, can't manage them anymore. As a workaround,
support to generate similar install script and upload it as static
file.

@kenhys
Copy link
Contributor Author

kenhys commented Sep 24, 2024

Expected to be used with:

ruby make-install-script.rb /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io --channel 5 --verify -d
Template path: /work/fluent/fluent-package-builder/f-p-b.repo/fluent-package/make-install-script.erb
Processing fluent-package 5 ...
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-redhat-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-redhat-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-amazon2-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-amazon2-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-amazon2023-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-amazon2023-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-noble-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-noble-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-jammy-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-jammy-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-focal-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-focal-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-debian-bullseye-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-debian-bullseye-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-debian-bookworm-fluent-package5.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-debian-bookworm-fluent-package5.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-redhat-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-redhat-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-amazon2-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-amazon2-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-amazon2023-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-amazon2023-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-noble-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-noble-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-jammy-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-jammy-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-ubuntu-focal-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-ubuntu-focal-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-debian-bullseye-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-debian-bullseye-fluent-package5-lts.sh
Generated: /work/fluent/fluent-package-builder/fluentd.cdn.cncf.io/sh/install-debian-bookworm-fluent-package5-lts.sh
[OK] Compared with: https://toolbelt.treasuredata.com/sh/install-debian-bookworm-fluent-package5-lts.sh

@kenhys kenhys force-pushed the make-install-script branch 3 times, most recently from 917344b to 84e3d14 Compare September 24, 2024 07:33
@kenhys
Copy link
Contributor Author

kenhys commented Sep 24, 2024

3, 4, and 5 was supported.

@kenhys kenhys force-pushed the make-install-script branch 2 times, most recently from 251b8b0 to fd81b86 Compare September 24, 2024 07:51
@kenhys
Copy link
Contributor Author

kenhys commented Sep 24, 2024

2, 2.5 was supported.

@kenhys kenhys force-pushed the make-install-script branch 2 times, most recently from c02b3b3 to e6fa548 Compare September 24, 2024 08:23
@kenhys
Copy link
Contributor Author

kenhys commented Sep 27, 2024

It might better to refactor more.

@kenhys
Copy link
Contributor Author

kenhys commented Sep 27, 2024

And need to archive current install script.

@kenhys kenhys force-pushed the make-install-script branch 2 times, most recently from 06a671b to 86e231d Compare September 27, 2024 05:12
@kenhys
Copy link
Contributor Author

kenhys commented Sep 27, 2024

Supported to make installation scripts archive.

@kenhys
Copy link
Contributor Author

kenhys commented Sep 27, 2024

Still 2.5 target is broken.

@kenhys kenhys marked this pull request as ready for review September 27, 2024 05:55
@kenhys
Copy link
Contributor Author

kenhys commented Sep 27, 2024

How to verify

  1. ruby make-install-script.rb -b PATH_TO_REPOSITORY

it creates installation script backup under toolbelt/*

  1. ruby make-install-script -v PATH_TO_REPOSITORY

It checks installation script under PATH_TO_REPOSITORY and verify it with https://toolbelt.treasuredata.com

  1. ruby make-install-script -v -a PATH_TO_REPOSITORY

It checks installation script under PATH_TO_REPOSITORY and verify it with locally backup installation script.

@kenhys kenhys requested a review from daipom September 27, 2024 06:02
Currently, fluent-package install script is hosted on
https://toolbelt.treasuredata.com and maintained under private
repository.

It rely on deploying commercial cloud service and if we lost access to
that private repository, can't manage them anymore. As a workaround,
support to generate similar install script and upload it as static
file.

Signed-off-by: Kentaro Hayashi <[email protected]>
These scripts were generated with make-install-script.rb -b PATH_TO_REPOSITORY

Signed-off-by: Kentaro Hayashi <[email protected]>
@kenhys
Copy link
Contributor Author

kenhys commented Oct 31, 2024

rebased with recent master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant