Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport ci deb: tweak downgrade test case #732

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

kenhys
Copy link
Contributor

@kenhys kenhys commented Nov 11, 2024

After removing fluent-package and td-agent,
fluentd.service file is linked to nonexistent file (masked), but td-agent service is still active unexpectedly, so explicitly stop that service.

@kenhys kenhys added this to the 5.0.5 milestone Nov 11, 2024
@daipom
Copy link
Contributor

daipom commented Nov 11, 2024

Thanks! Should we merge this into the master, and backport it to the v5 branch?

@kenhys kenhys force-pushed the backport-fix-downgrade branch 2 times, most recently from cfb8f13 to 154e7da Compare November 11, 2024 07:02
@kenhys kenhys changed the title ci deb: tweak downgrade test case Backport ci deb: tweak downgrade test case Nov 11, 2024
@kenhys kenhys force-pushed the backport-fix-downgrade branch 2 times, most recently from a1f1e51 to 647a634 Compare November 12, 2024 04:50
@kenhys
Copy link
Contributor Author

kenhys commented Nov 12, 2024

It seems that it is enough just not to unmask here.

Now, no need to unmask td-agent because transitional
td-agent package was installed before.

Signed-off-by: Kentaro Hayashi <[email protected]>
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@daipom daipom merged commit ed42a41 into fluent-package-v5 Nov 13, 2024
54 checks passed
@daipom daipom deleted the backport-fix-downgrade branch November 13, 2024 02:25
@kenhys kenhys mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants