-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FLOE-471: Transfer pouchPersisted and eventInTimeAware grades from Learning Dashboard prototype to new MyL3 repo #1
Conversation
</ul> | ||
</div> | ||
<script> | ||
fluid.defaults("floe.dashboard.pouchPersistedInlineEdit", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lengthy script block should be broken out into a .js file
@amb26 I'm having some trouble understanding the comments about reusing the logic from the CouchDB dataSource grade - that appears to be a mixin grade for the node-based |
@waharnum, as we discussed in our meeting, there is an approach to browserifying the required deps and just using the existing grade, but as you are not just talking about tests, it sounds like you (also) need a jQuery-backed dataSource. Not sure I can fit anything in this week, let's discuss in today's meeting. |
Closing this PR since @simonbates is starting a new round of work on this project. |
Per this Jira
These grades have important base functionality (persistence and time-awareness) for the MyL3 project.
Since the PR introduces a lot of files, these are the ones that should be reviewed:
examples/*
src/js/*
tests/html
tests/js