Add custom bottle multiplier for Lifi #2542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-d
requested changes
Feb 6, 2024
| @@ -79,6 +79,8 @@ function ErrorBoundary(error: Error) { | |||
|
|
|||
| const ADJUSTED_BOTTLE_MULTIPLIER = 12; | |||
|
|
|||
| const ADJUSTED_BOTTLE_MULTIPLIER = 24; | |||
There was a problem hiding this comment.
this is the same variable name as above
| // reward lifi bottles disproporationately (24x) compared to the usual (12x) | ||
|
|
||
| let adjustedLootboxCount = lootboxCount; | ||
| switch (true) { |
There was a problem hiding this comment.
this has redundant logic (if application is lifi shouldMultiplyBottles is always going to be true), and should be a ternary such as
const adjustedLootboxCount = application === "lifi"
? lootboxCount * lifiMultiplier
: application !== "none"
? lootboxCount * bottleMultiplier
: lootboxCount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.