Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule Merge Queue builds #4068

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Dec 3, 2024

Merge Queue builds are post-submit-like

  • They need to be build on prod
  • They are mirrored to GoB
  • They need to report back to the presubmit pubsub
  • They do not technically have a PR associated with check_runs 1.
  • They should not touch the same firebase / datastore tables as post submit 2

Footnotes

  1. The PR number is encoded in the magical branch. We do not worry about that right now as we will not run tests after making prod builds. Testing occurs in post-submit land with the same binaries.

  2. These tables are used for rendering progress on the dashboard. Future projects may include custom dashboards for PRs and Merge Queues if we want to reduce our quota to GitHub.

@jtmcdole jtmcdole requested a review from yjbanov December 3, 2024 16:47
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/luci_build_service.dart Outdated Show resolved Hide resolved
@jtmcdole jtmcdole force-pushed the schedulePostSubmitBuilds branch from 37dcd1c to e9928bf Compare December 3, 2024 23:43
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 4, 2024
app_dart/lib/src/service/scheduler.dart Show resolved Hide resolved
app_dart/lib/src/service/scheduler.dart Show resolved Hide resolved
app_dart/lib/src/service/scheduler.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/scheduler.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/scheduler.dart Outdated Show resolved Hide resolved
app_dart/lib/src/service/scheduler.dart Outdated Show resolved Hide resolved
app_dart/test/service/scheduler_test.dart Show resolved Hide resolved
@jtmcdole jtmcdole removed the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 4, 2024
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants