Skip to content

Commit

Permalink
Add scrollbar to log details (#6917)
Browse files Browse the repository at this point in the history
![](https://media.giphy.com/media/Y4pAQv58ETJgRwoLxj/giphy-downsized.gif)

The only part of the logging display that I found confusing was that there was no scroll bar, so I have added one here.

Fixes #6797
  • Loading branch information
CoderDake authored Dec 8, 2023
1 parent c8af1c0 commit 24d5d61
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 7 deletions.
14 changes: 8 additions & 6 deletions packages/devtools_app/lib/src/screens/logging/_log_details.dart
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,14 @@ class _LogDetailsState extends State<LogDetails>
title: _LogDetailsHeader(log: log),
child: Padding(
padding: const EdgeInsets.all(denseSpacing),
child: SingleChildScrollView(
controller: scrollController,
child: SelectableText(
log?.prettyPrinted() ?? '',
textAlign: TextAlign.left,
style: theme.fixedFontStyle,
child: Scrollbar(
child: SingleChildScrollView(
controller: scrollController,
child: SelectableText(
log?.prettyPrinted() ?? '',
textAlign: TextAlign.left,
style: theme.fixedFontStyle,
),
),
),
),
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ TODO: Remove this section if there are not any general updates.

## Logging updates

TODO: Remove this section if there are not any general updates.
* Added scrollbar to details pane. - [#6917](https://github.com/flutter/devtools/pull/6917)

## App size tool updates

Expand Down

0 comments on commit 24d5d61

Please sign in to comment.