[devtools_app] update dependency on pkg:file_selector #6762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows version of file_selector_web that support wasm
kenzieschmoll
approved these changes
Nov 17, 2023
srujzs
pushed a commit
to srujzs/devtools
that referenced
this pull request
Nov 20, 2023
Allows version of file_selector_web that support wasm ![build.yaml badge] If you need help, consider asking for help on [Discord]. [build.yaml badge]: https://github.com/flutter/devtools/actions/workflows/build.yaml/badge.svg
stuartmorgan
reviewed
Dec 5, 2023
| file_selector_linux: ^0.9.0 | ||
| file_selector_macos: ^0.9.0 | ||
| file_selector_web: ^0.9.0 | ||
| file_selector_windows: ^0.9.0 |
There was a problem hiding this comment.
Is devtools interacting directly with any implementation package? If not, none of these except file_selector is still necessary; they are all endorsed by file_selector 1.0.0.
There was a problem hiding this comment.
Sure! I was just riffing on what's there. Zero clue about why all of these show up!
There was a problem hiding this comment.
The original dependencies date back to before file_selector's implementation had moved and been endorsed, IIRC.
There was a problem hiding this comment.
We only import file_selector in the DevTools code. Can we remove all these platform specific imports then?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows version of file_selector_web that support wasm
Pre-launch Checklist
///).If you need help, consider asking for help on Discord.