Show whether the app is using Impeller or Skia in the performance page #6771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
requested review from
bkonyi and
jonahwilliams
and removed request for
a team
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
force-pushed
the
impeller-notice
branch
from
365059b to
04a39b7
Compare
srujzs
pushed a commit
to srujzs/devtools
that referenced
this pull request
Nov 20, 2023
srujzs
pushed a commit
to srujzs/devtools
that referenced
this pull request
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4467
Currently this only shows one of two values: 'Impeller' or 'Skia'. @jonahwilliams is this accurate?
I am open to suggestions for a better spot to put this data.
This PR also: