Skip to content

Commit

Permalink
last one?
Browse files Browse the repository at this point in the history
  • Loading branch information
mdebbar committed Dec 11, 2024
1 parent 2962009 commit 495cf14
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/web_ui/test/engine/initialization_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ void testMain() {
expect(engineInitializer, isNotNull);
expect(js_util.hasProperty(engineInitializer!, 'initializeEngine'), isTrue, reason: 'Missing FlutterEngineInitializer method: initializeEngine.');
expect(js_util.hasProperty(engineInitializer!, 'autoStart'), isTrue, reason: 'Missing FlutterEngineInitializer method: autoStart.');
});
// https://github.com/flutter/flutter/issues/160096
}, skip: ui_web.browser.isFirefox);

test('bootstrapEngine does auto-start when _flutter.loader.didCreateEngineInitializer does not exist', () async {
loader = null;
Expand Down Expand Up @@ -81,7 +82,8 @@ void testMain() {
// After starting the engine, the meta-generator tag should be on the page
final DomElement? meta = domDocument.querySelector('meta[name=generator][content=Flutter]');
expect(meta, isNotNull, reason: 'The generator meta-tag should be added when Flutter initializes its UI.');
});
// https://github.com/flutter/flutter/issues/160096
}, skip: ui_web.browser.isFirefox);

// We cannot test anymore, because by now the engine has registered some stuff that can't be rewound back.
// Like the `ext.flutter.disassemble` developer extension.
Expand Down
1 change: 1 addition & 0 deletions lib/web_ui/test/engine/semantics/semantics_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ void main() {
Future<void> testMain() async {
if (ui_web.browser.isFirefox) {
// Firefox gets stuck in bootstrapAndRunApp for a mysterious reason.
// https://github.com/flutter/flutter/issues/160096
return;
}

Expand Down

0 comments on commit 495cf14

Please sign in to comment.