Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved device buffer to an untracked handle #57021

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Dec 6, 2024

fixes: flutter/flutter#159745

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke force-pushed the untracked-buffers branch 5 times, most recently from 3890efc to e172830 Compare December 6, 2024 21:40
@gaaclarke gaaclarke marked this pull request as ready for review December 6, 2024 21:40
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 6, 2024
Copy link
Contributor

auto-submit bot commented Dec 6, 2024

auto label is removed for flutter/engine/57021, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chinmaygarde
Copy link
Member

Looks like the CI failures are real.

@gaaclarke
Copy link
Member Author

heads up @jonahwilliams this changed since you approved it. it's a minor change where we will store the label and set it when the buffer is created if the label is set before the lazy buffer is created.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 9, 2024
@auto-submit auto-submit bot merged commit 520fbc1 into flutter:main Dec 9, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 10, 2024
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Dec 10, 2024
…160008)

flutter/engine@4d0e9ac...2069db8

2024-12-10 [email protected] [Impeller] simplify render target
size rounding up heuristics. (flutter/engine#57043)
2024-12-09 [email protected] moved device
buffer to an untracked handle (flutter/engine#57021)
2024-12-09 [email protected] Roll Skia from 14f8f6d984ff to
3a58be4817a8 (3 revisions) (flutter/engine#57073)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[impeller] reduce reliance on Reactor
3 participants