-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moved device buffer to an untracked handle #57021
Conversation
3890efc
to
e172830
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
auto label is removed for flutter/engine/57021, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Looks like the CI failures are real. |
heads up @jonahwilliams this changed since you approved it. it's a minor change where we will store the label and set it when the buffer is created if the label is set before the lazy buffer is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
acdc102
to
c0add79
Compare
…160008) flutter/engine@4d0e9ac...2069db8 2024-12-10 [email protected] [Impeller] simplify render target size rounding up heuristics. (flutter/engine#57043) 2024-12-09 [email protected] moved device buffer to an untracked handle (flutter/engine#57021) 2024-12-09 [email protected] Roll Skia from 14f8f6d984ff to 3a58be4817a8 (3 revisions) (flutter/engine#57073) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
fixes: flutter/flutter#159745
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.