Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT SUBMIT] format test #57164

Closed
wants to merge 7 commits into from
Closed

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Dec 12, 2024

Diff produced on CI:

diff --git a/lib/web_ui/dev/build.dart b/lib/web_ui/dev/build.dart
index df1fe19123..0000000000 100644
--- a/lib/web_ui/dev/build.dart
+++ b/lib/web_ui/dev/build.dart
@@ -28,34 +28,29 @@ class BuildCommand extends Command<bool> with ArgUtils<bool> {
argParser.addFlag(
'watch',
abbr: 'w',
-      help:
-          'Run the build in watch mode so it rebuilds whenever a change is '
+      help: 'Run the build in watch mode so it rebuilds whenever a change is '
'made. Disabled by default.',
);
argParser.addFlag(
'host',
-      help:
-          'Build the host build instead of the wasm build, which is '
+      help: 'Build the host build instead of the wasm build, which is '
'currently needed for `flutter run --local-engine` to work.',
);
argParser.addFlag(
'profile',
-      help:
-          'Build in profile mode instead of release mode. In this mode, the '
+      help: 'Build in profile mode instead of release mode. In this mode, the '
'output will be located at "out/wasm_profile".\nThis only applies to '
'the wasm build. The host build is always built in release mode.',
);
argParser.addFlag(
'debug',
-      help:
-          'Build in debug mode instead of release mode. In this mode, the '
+      help: 'Build in debug mode instead of release mode. In this mode, the '
'output will be located at "out/wasm_debug".\nThis only applies to '
'the wasm build. The host build is always built in release mode.',
);
argParser.addFlag(
'dwarf',
-      help:
-          'Embed DWARF debugging info into the output wasm modules. This is '
+      help: 'Embed DWARF debugging info into the output wasm modules. This is '
'only valid in debug mode.',
);
}
@@ -170,3 +165,4 @@ class NinjaPipelineStep extends ProcessStep {
return startProcess('autoninja', <String>['-C', buildDirectory, ...targets]);
}
}

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added the platform-web Code specifically for the web engine label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant