Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update super-editor commit hash #292

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

Renzo-Olivares
Copy link
Contributor

This change updates the super-editor commit hash to include updated golden_toolkit dependencies that migrate:

  • TestWindow.textScaleFactorTestValue
  • TestWindow.clearTextScaleFactorTestValue
  • TestWindow.platformBrightnessTestValue
  • TestWindow.clearPlatformBrightnessTestValue

to use PlatformDispatcher.

superlistapp/super_editor@34165a0

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@auto-submit auto-submit bot merged commit 51b590c into flutter:main Sep 1, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants