Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package update #75

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

pythonhubdev
Copy link
Contributor

  • Updated packages to latest version
  • Added lint rules with analysis_options.yaml
  • Updated GitHub actions
  • Removed containers and switched to GitHub actions for setting up Dart SDK

@pythonhubdev
Copy link
Contributor Author

@vkammerer I have updated with latest PR here as requested

@pythonhubdev pythonhubdev mentioned this pull request Jan 12, 2024
3 tasks
@pythonhubdev
Copy link
Contributor Author

Hi @vkammerer any update on this PR?

@pythonhubdev
Copy link
Contributor Author

@lig can you review this PR

vkammerer pushed a commit to pythonhubdev/import_sorter that referenced this pull request Jan 19, 2024
@vkammerer vkammerer force-pushed the feat/package_update branch from 098df94 to 7f17800 Compare January 19, 2024 11:52
Copy link
Collaborator

@vkammerer vkammerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR @pythonhubdev.

I checked out your branch locally, and I could see that the dart analyzer reported several issues with it.

I just pushed 7f17800 which addresses theses issues, and makes the tests pass.

analysis_options.yaml Outdated Show resolved Hide resolved
@vkammerer vkammerer merged commit 158246d into fluttercommunity:master Jan 19, 2024
3 checks passed
@pythonhubdev pythonhubdev deleted the feat/package_update branch January 19, 2024 12:22
@pythonhubdev
Copy link
Contributor Author

Can we make a new release to pub.dev? @vkammerer it's been 2 years since the last release on pub

@vkammerer
Copy link
Collaborator

This was finally published on pub.dev, under the version 5.0.0-releasecandidate.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants