fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 #2169

vbuberen · 2023-09-30T11:47:14Z

Description

We have multiple bug reports about issues when connectivity_plus plugin is used in a project build with Xcode 15. Apparently, after some investigation found out that Xcode 15 supports only iOS 12 and newer and not all APIs work fine.
Here is an example of similar solution: https://stackoverflow.com/a/77151438/7339798
In order to support Xcode 15 I am bumping min iOS version for the plugin to 12, so users won't have to modify their build configs on iOS.
Marking as a breaking change to be sure I don't break projects for somebody who still supports <12 iOS versions.

Related Issues

Supposed to close quite a lot of issues:

Fixes #1955
Fixes #2136
Fixes #2154
Fixes #2155
Fixes #2159
Fixes #2162
Fixes #2166
Fixes #2152

Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I titled the PR using Conventional Commits.
I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
All existing and new tests are passing.
The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
No, this is not a breaking change.

nohli

Oh boi, quite a few issues you've found 🙏🏽

vbuberen · 2023-09-30T13:24:25Z

I will wait for a confirmation from one of the users with this problem as I currently don't have a physical iOS device to check the fix.

vbuberen · 2023-10-02T10:14:52Z

Ok, we have a first confirmation: #2155 (comment)

Thus, merging to release plugins somewhere this week.

NamanShergill · 2023-10-03T13:06:02Z

@vbuberen Directly using this ref is not working either, it's failing at this part still

NamanShergill · 2023-10-03T13:07:38Z

Not really familiar with Xcode so not sure where to find the relevant logs to attach, please let me know if I need to send anything specific

NamanShergill · 2023-10-03T13:10:16Z

Flutter version: 3.13.6
Xcode version: 15.0
Device OS: iPadOS 16.3 (20D47)

Thread 1 Queue : com.apple.main-thread (serial)
#0	0x0000000000000000 in 0x00000000 ()
#1	0x00000001005b5400 in PathMonitorConnectivityProvider.ensurePathMonitor() at /Users/naman/.pub-cache/git/plus_plugins-cf7d93fbfc76830acf2db755543cf4235a49df60/packages/connectivity_plus/connectivity_plus/ios/Classes/PathMonitorConnectivityProvider.swift:49
#2	0x00000001005b5238 in PathMonitorConnectivityProvider.init() at /Users/naman/.pub-cache/git/plus_plugins-cf7d93fbfc76830acf2db755543cf4235a49df60/packages/connectivity_plus/connectivity_plus/ios/Classes/PathMonitorConnectivityProvider.swift:34
#3	0x00000001005b5280 in @objc PathMonitorConnectivityProvider.init() ()
#4	0x00000001005b50c8 in PathMonitorConnectivityProvider.__allocating_init() ()
#5	0x00000001005b6d28 in static SwiftConnectivityPlusPlugin.register(with:) at /Users/naman/.pub-cache/git/plus_plugins-cf7d93fbfc76830acf2db755543cf4235a49df60/packages/connectivity_plus/connectivity_plus/ios/Classes/SwiftConnectivityPlusPlugin.swift:28
#6	0x00000001005b7004 in @objc static SwiftConnectivityPlusPlugin.register(with:) ()
#7	0x00000001005b4048 in +[ConnectivityPlusPlugin registerWithRegistrar:] at /Users/naman/.pub-cache/git/plus_plugins-cf7d93fbfc76830acf2db755543cf4235a49df60/packages/connectivity_plus/connectivity_plus/ios/Classes/ConnectivityPlusPlugin.m:13
#8	0x000000010010c074 in +[GeneratedPluginRegistrant registerWithRegistry:] at /proj/ios/Runner/GeneratedPluginRegistrant.m:96
#9	0x000000010010c46c in AppDelegate.application(_:didFinishLaunchingWithOptions:) at /proj/ios/Runner/AppDelegate.swift:10
#10	0x000000010010c75c in @objc AppDelegate.application(_:didFinishLaunchingWithOptions:) ()
#11	0x00000001acbeea50 in -[UIApplication _handleDelegateCallbacksWithOptions:isSuspended:restoreState:] ()
#12	0x00000001acbee174 in -[UIApplication _callInitializationDelegatesWithActions:forCanvas:payload:fromOriginatingProcess:] ()
#13	0x00000001acbed150 in -[UIApplication _runWithMainScene:transitionContext:completion:] ()
#14	0x00000001acbecd9c in -[_UISceneLifecycleMultiplexer completeApplicationLaunchWithFBSScene:transitionContext:] ()
#15	0x00000001ac932e74 in _UIScenePerformActionsWithLifecycleActionMask ()
#16	0x00000001acc74d78 in __101-[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:]_block_invoke ()
#17	0x00000001acb25adc in -[_UISceneLifecycleMultiplexer _performBlock:withApplicationOfDeactivationReasons:fromReasons:] ()
#18	0x00000001acb25904 in -[_UISceneLifecycleMultiplexer _evalTransitionToSettings:fromSettings:forceExit:withTransitionStore:] ()
#19	0x00000001acb254b4 in -[_UISceneLifecycleMultiplexer uiScene:transitionedFromState:withTransitionContext:] ()
#20	0x00000001acb25380 in __186-[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:]_block_invoke ()
#21	0x00000001ad20956c in +[BSAnimationSettings(UIKit) tryAnimatingWithSettings:fromCurrentState:actions:completion:] ()
#22	0x00000001ad2a3568 in _UISceneSettingsDiffActionPerformChangesWithTransitionContextAndCompletion ()
#23	0x00000001ac9d1374 in -[_UIWindowSceneFBSSceneTransitionContextDrivenLifecycleSettingsDiffAction _performActionsForUIScene:withUpdatedFBSScene:settingsDiff:fromSettings:transitionContext:lifecycleActionType:] ()
#24	0x00000001ace44294 in __64-[UIScene scene:didUpdateWithDiff:transitionContext:completion:]_block_invoke.214 ()
#25	0x00000001acaa39a0 in -[UIScene _emitSceneSettingsUpdateResponseForCompletion:afterSceneUpdateWork:] ()
#26	0x00000001acaa3810 in -[UIScene scene:didUpdateWithDiff:transitionContext:completion:] ()
#27	0x00000001acaa2d64 in -[UIApplication workspace:didCreateScene:withTransitionContext:completion:] ()
#28	0x00000001acaa2af0 in -[UIApplicationSceneClientAgent scene:didInitializeWithEvent:completion:] ()
#29	0x00000001c0438e90 in -[FBSScene _callOutQueue_agent_didCreateWithTransitionContext:completion:] ()
#30	0x00000001c04788f8 in __92-[FBSWorkspaceScenesClient createSceneWithIdentity:parameters:transitionContext:completion:]_block_invoke.78 ()
#31	0x00000001c043cc24 in -[FBSWorkspace _calloutQueue_executeCalloutFromSource:withBlock:] ()
#32	0x00000001c0478530 in __92-[FBSWorkspaceScenesClient createSceneWithIdentity:parameters:transitionContext:completion:]_block_invoke ()
#33	0x00000001007e5ff0 in _dispatch_client_callout ()
#34	0x00000001007e9a6c in _dispatch_block_invoke_direct ()
#35	0x00000001c0446d40 in __FBSSERIALQUEUE_IS_CALLING_OUT_TO_A_BLOCK__ ()
#36	0x00000001c04468dc in -[FBSSerialQueue _targetQueue_performNextIfPossible] ()
#37	0x00000001c0449184 in -[FBSSerialQueue _performNextFromRunLoopSource] ()
#38	0x00000001aa795f24 in __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ ()
#39	0x00000001aa7a22fc in __CFRunLoopDoSource0 ()
#40	0x00000001aa726220 in __CFRunLoopDoSources0 ()
#41	0x00000001aa73bb7c in __CFRunLoopRun ()
#42	0x00000001aa740eb0 in CFRunLoopRunSpecific ()
#43	0x00000001e4088368 in GSEventRunModal ()
#44	0x00000001acc36668 in -[UIApplication _run] ()
#45	0x00000001acc362cc in UIApplicationMain ()
#46	0x000000010010c8d4 in main at /proj/ios/Runner/AppDelegate.swift:5
#47	0x00000001c902c960 in start ()

vbuberen · 2023-10-03T13:11:49Z

Are you sure you use the patched version? I had confirmation from other people as well that patch worked

NamanShergill · 2023-10-03T13:12:53Z

@vbuberen yes, you can see the commit ref in this part of the error, in the path:

#1	0x00000001005b5400 in PathMonitorConnectivityProvider.ensurePathMonitor() at /Users/naman/.pub-cache/git/plus_plugins-cf7d93fbfc76830acf2db755543cf4235a49df60/packages/connectivity_plus/connectivity_plus/ios/Classes/PathMonitorConnectivityProvider.swift:49

NamanShergill · 2023-10-03T14:02:00Z

@vbuberen I was about to update to iPadOS 17 before I ran into this, however considering this issue is happening only on physical devices, should I stay on 16.3 to verify any fixes or provide any logs that might be needed?

vbuberen · 2023-10-03T14:43:46Z

I was about to update to iPadOS 17 before I ran into this, however considering this issue is happening only on physical devices, should I stay on 16.3 to verify any fixes or provide any logs that might be needed?

Thank you for such suggestion. What I would ask you to do is to open a new issue where we can continue the discussion. Also, would be great if you provide me with some details of iOS part of your project, like iOS deployment target in that issue.

As to updating to iOS 17 or not - if it is Ok for you, please don't update, so we could validate that the fix work if it turns out the problem only happens on iOS 16 (which I doubt and believe that the problem is in the Xcode 15 itself).

NamanShergill · 2023-10-03T16:34:17Z

As to updating to iOS 17 or not - if it is Ok for you, please don't update, so we could validate that the fix work if it turns out the problem only happens on iOS 16 (which I doubt and believe that the problem is in the Xcode 15 itself).

I am able to build the project just fine on my iPhone which is on iOS 17 using Xcode 15. It's happening just on iPadOS 16.3 for me right now. I won't update my iPad for now in case it actually is a <iOS 17 problem.

Also, would be great if you provide me with some details of iOS part of your project, like iOS deployment target in that issue.

Will open a new issue with the details in a few mins, would be including the process I used to build for both min 11.0 target and 12.0, anything else you need me to include?

NamanShergill · 2023-10-03T17:22:42Z

@vbuberen I was able to get it to work, it wasn't an issue with the plugin, for some reason Xcode was resetting the pod's minimum target to 11, even if the plugin now specifies 12, and it did it for the example project as well (I changed the ref to this fix).

Once I saw that, manually setting it back to 12 in the Xcode UI itself, fixed the issue. (I checked the bundled plist of the plugin, it was still saying 12 even before I changed it, but it was 11 in Xcode.)

I am not sure why it Is was doing that but the plugin is working fine, it was an issue with XCode, reinstalling it fixed the problem.

NamanShergill · 2023-10-03T17:25:03Z

if it turns out the problem only happens on iOS 16 (which I doubt and believe that the problem is in the Xcode 15 itself).

This turned out to be the case after all

vbuberen · 2023-10-03T18:47:50Z

Thank you for researching and providing feedback. It was really helpful.

- (fluttercommunity/plus_plugins#2169)

this is needed as otherwise there are weird crashes, eg. when opening connectivity view (there are sth. simple as `let monitor = NWPathMonitor()`) as reported eg. at fluttercommunity/plus_plugins#2169 it seems xcode15 does not support ios<12 fully fortunately, this does not change our minimum supported devices as all of them get get ios12.

niypoo · 2023-10-18T09:43:14Z

As to updating to iOS 17 or not - if it is Ok for you, please don't update, so we could validate that the fix work if it turns out the problem only happens on iOS 16 (which I doubt and believe that the problem is in the Xcode 15 itself).

I am able to build the project just fine on my iPhone which is on iOS 17 using Xcode 15. It's happening just on iPadOS 16.3 for me right now. I won't update my iPad for now in case it actually is a <iOS 17 problem.

Also, would be great if you provide me with some details of iOS part of your project, like iOS deployment target in that issue.

Will open a new issue with the details in a few mins, would be including the process I used to build for both min 11.0 target and 12.0, anything else you need me to include?

Thanks , you saved my day 👏

marianhlavac · 2023-10-19T13:38:17Z

Info for those arriving to this PR when Googling:

The issue is confirmed when building for iOS <17, active issue is here #2276

This fixes a crash on iOS devices with any iOS less than 17. See: fluttercommunity/plus_plugins#2169

ueman · 2023-12-15T08:22:28Z

I get a

Compiling for iOS 12.0, but module 'Reachability' has a minimum deployment target of iOS 12.4

error now. Xcode still supports iOS 12.0 though. Is the 12.4 requirement intentional?

vbuberen · 2023-12-15T08:33:12Z

No, it is not required. We already had that issue with Reachability pod some time ago. It is not the plugin, but something else with Cocoapods.

vbuberen · 2023-12-15T08:36:22Z

You have Reachability pod updated locally due to some other dependency, I guess.
Check out this comment, for example
pusher/pusher-websocket-swift#235 (comment)

fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15

16b361d

vbuberen added the connectivity_plus Connectivity Plus label Sep 30, 2023

Add deployment target for example app

795ecef

vbuberen requested a review from nohli September 30, 2023 12:21

nohli approved these changes Sep 30, 2023

View reviewed changes

vbuberen merged commit cf7d93f into main Oct 2, 2023
20 checks passed

vbuberen deleted the update/connectivity_plus_min_ios branch October 2, 2023 10:14

syedmurtaza108 mentioned this pull request Oct 3, 2023

[Bug]: ERROR encountered only below iOS 17 devices "Thread 1: EXC_BAD_ACCESS (code=1, address=0x0)" #2162

Closed

vbuberen mentioned this pull request Oct 3, 2023

[Bug]: Install plus_plugins package got crash in iPhone6 & iPhone11 #2203

Closed

7 tasks

This was referenced Oct 4, 2023

[Bug]: Thread 1: EXC_BAD_ACCESS (code=1, address=0x0) #2216

Closed

[Bug]: Ios App Crashed only v16.6.1 #2223

Closed

narumi147 added a commit to chaldea-center/chaldea that referenced this pull request Oct 7, 2023

Bump min iOS to 12 to fix connectivity_plus

fbcb886

- (fluttercommunity/plus_plugins#2169)

vbuberen mentioned this pull request Oct 7, 2023

I got this error When i try to run the Iphone 8 plus simulator self connectivity_plus.PathMonitorConnectivityProvider 0x00006000013f3ab0 #2152

Closed

7 tasks

r10s mentioned this pull request Oct 7, 2023

ios 16.6.1 crashes when opening the connectivity view deltachat/deltachat-ios#1930

Closed

r10s mentioned this pull request Oct 7, 2023

raise deployment target from ios11 to ios12 deltachat/deltachat-ios#1931

Merged

vbuberen mentioned this pull request Oct 11, 2023

[Bug]: crash with NWPathMonitor #1953

Closed

7 tasks

david-avetikov mentioned this pull request Oct 12, 2023

upgrade connectivity_plus version to ^5.0.0 livekit/client-sdk-flutter#384

Merged

vbuberen mentioned this pull request Oct 19, 2023

[Bug]: Connectivity Plus: App crashes with version 5.0.1 #2276

Closed

8 tasks

JamesMcIntosh mentioned this pull request Oct 22, 2023

Connectivity plus dependency is broken with XCode15 requiring iOS 12 jogboms/flutter_offline#59

Closed

AbdulazizRasulbek mentioned this pull request Oct 25, 2023

Connectivity_plus dependency update aissat/easy_localization_loader#55

Closed

confiks pushed a commit to MinBZK/nl-wallet that referenced this pull request Nov 7, 2023

Upgrade connectivity_plus plugin to 5.0.1

b3b9207

This fixes a crash on iOS devices with any iOS less than 17. See: fluttercommunity/plus_plugins#2169

CameronPorter95 mentioned this pull request Nov 8, 2023

[Bug]: crash on NWPathMonitor Iterable/iterable-swift-sdk#688

Open

biklas7 mentioned this pull request Nov 16, 2023

Bump connectivity_plus to latest version to avoid possible iOS crash Iteo/connecteo#36

Closed

juliansteenbakker mentioned this pull request Nov 20, 2023

After upgrading to Flutter 3.16 and XCode 15.0.1 I get Error vailability_version_check.cc(39)] Check failed on iOS less than 17 flutter/flutter#138711

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 #2169

fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 #2169

vbuberen commented Sep 30, 2023 •

edited

Loading

nohli left a comment

vbuberen commented Sep 30, 2023

vbuberen commented Oct 2, 2023

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 •

edited

Loading

vbuberen commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

vbuberen commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023

vbuberen commented Oct 3, 2023

niypoo commented Oct 18, 2023

marianhlavac commented Oct 19, 2023

ueman commented Dec 15, 2023

vbuberen commented Dec 15, 2023 •

edited

Loading

vbuberen commented Dec 15, 2023

fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 #2169

fix(connectivity_plus)!: Bump min iOS to 12 to support XCode 15 #2169

Conversation

vbuberen commented Sep 30, 2023 • edited Loading

Description

Related Issues

Checklist

Breaking Change

nohli left a comment

Choose a reason for hiding this comment

vbuberen commented Sep 30, 2023

vbuberen commented Oct 2, 2023

NamanShergill commented Oct 3, 2023 • edited Loading

NamanShergill commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 • edited Loading

vbuberen commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 • edited Loading

NamanShergill commented Oct 3, 2023 • edited Loading

vbuberen commented Oct 3, 2023

NamanShergill commented Oct 3, 2023 • edited Loading

NamanShergill commented Oct 3, 2023 • edited Loading

NamanShergill commented Oct 3, 2023

vbuberen commented Oct 3, 2023

niypoo commented Oct 18, 2023

marianhlavac commented Oct 19, 2023

ueman commented Dec 15, 2023

vbuberen commented Dec 15, 2023 • edited Loading

vbuberen commented Dec 15, 2023

vbuberen commented Sep 30, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

NamanShergill commented Oct 3, 2023 •

edited

Loading

vbuberen commented Dec 15, 2023 •

edited

Loading