Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update minimum iOS version to 12.1 for build error #2379

Closed
wants to merge 1 commit into from

Conversation

MarlonJD
Copy link

@MarlonJD MarlonJD commented Nov 16, 2023

Description

Flutter (Channel stable, 3.16.0, on macOS 14.0 23A344 darwin-arm64, locale tr-TR)
Android toolchain - develop for Android devices (Android SDK version 34.0.0)
Xcode - develop for iOS and macOS (Xcode 15.0.1)
connectivity_plus: 5.0.1

Cannot build on iOS with iOS: 12 with this error:

Launching lib/main.dart on iPhone 15 Pro Max in debug mode...
main.dart:1
Xcode build done.                                           34,6s
Failed to build iOS app
Swift Compiler Error (Xcode): Compiling for iOS 12.0, but module 'Reachability' has a minimum deployment target of iOS 12.1: /Users/marlonjd/dev/monolibMobile/packages/monolibmobile/build/ios/Debug-iphonesimulator/ReachabilitySwift/Reachability.framework/Modules/Reachability.swiftmodule/x86_64-apple-ios-simulator.swiftmodule
/Users/marlonjd/.pub-cache/hosted/pub.dev/connectivity_plus-5.0.1/ios/Classes/ReachabilityConnectivityProvider.swift:1:7

Could not build the application for the simulator.
Error launching application on iPhone 15 Pro Max.

For this reason I changed to minimum target, but it's your call whether increasing or not iOS minimum deployment target.

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

It can be breaking change if your minimum target is 12.0

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen
Copy link
Collaborator

Do you have any sources or explanations on why 12.1 is needed?

@MarlonJD MarlonJD changed the title Update connectivity_plus.podspec Chore: update minimum iOS version to 12.1 for build error Nov 17, 2023
@MarlonJD
Copy link
Author

Do you have any sources or explanations on why 12.1 is needed?

I updated my PR detail with error.

@MarlonJD MarlonJD changed the title Chore: update minimum iOS version to 12.1 for build error chore: update minimum iOS version to 12.1 for build error Nov 17, 2023
@vbuberen
Copy link
Collaborator

I can't confirm this issue as example app builds fine with Xcode 15.0.1 locally for me from clean state for both simulator and real device.
So till there is a reproducer provided and more people having this issue report about it I can't accept this PR as it looks like you have some issues in your project setup.

@MarlonJD
Copy link
Author

@vbuberen can you check that you use 5.0.1 in pubspec.lock? I tried to reproduce I cannot recreate error because it was using 4.x.x version, try with 5.0.1 and flutter 3.16.0 and xcode 15.0.1. I tried 2 different machine and it gives me same error

@vbuberen
Copy link
Collaborator

vbuberen commented Nov 17, 2023

can you check that you use 5.0.1 in pubspec.lock?

I am pretty sure I know how to build an example app for plugins that I maintain, so yes, it is using the latest plugin version and Xcode 15.0.1 and Flutter 3.16.0.
Screenshot 2023-11-17 at 19 49 31

As I said you'd better check your project setup.

@MarlonJD
Copy link
Author

Interesting, I cannot build without change connectivity_plus target to 12.1 in Xcode, I'll check what the issue, thanks

@vbuberen
Copy link
Collaborator

I'll check what the issue, thanks

Maybe too obvious, but have you tried to do flutter clean and get all dependencies fetched again without cache? Maybe some issue with caching.

@MarlonJD
Copy link
Author

yes I did flutter clean, also cleaned pub cache, removed all podfile.lock, removed .symlinks/, Pods/, .podlock.

@vbuberen
Copy link
Collaborator

Still there is no information on why 12.1 might be needed. Closing.

@vbuberen vbuberen closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants