Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(connectivity_plus)!: bump MACOSX_DEPLOYMENT_TARGET from 10.11 to 10.14 #2588

Conversation

luisredondo
Copy link
Contributor

Description

Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14)

See #2529 for more details.

Related Issues

Resolves #2529

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Collaborator

@vbuberen vbuberen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

However, this shouldn't be marked as chore, because this way Melos will ignore this commit while generating changelogs and I would like this to be mentioned explicitly.
Moreover, this is a breaking change because there might be still people with old projects, so I don't to break their projects by releasing this change as a minor version bump.

I will adjust the title for every single one of your PRs, so no worries here.

@luisredondo
Copy link
Contributor Author

Thanks for your contribution.

However, this shouldn't be marked as chore, because this way Melos will ignore this commit while generating changelogs and I would like this to be mentioned explicitly. Moreover, this is a breaking change because there might be still people with old projects, so I don't to break their projects by releasing this change as a minor version bump.

I will adjust the title for every single one of your PRs, so no worries here.

I understand. Ok, let me know if there is anything I should do. 👍

@vbuberen vbuberen changed the title chore(connectivity_plus): bump MACOSX_DEPLOYMENT_TARGET from 10.11 to 10.14 refactor(connectivity_plus)!: bump MACOSX_DEPLOYMENT_TARGET from 10.11 to 10.14 Feb 15, 2024
@vbuberen vbuberen merged commit f6fe62d into fluttercommunity:main Feb 15, 2024
20 checks passed
@luisredondo luisredondo deleted the chore/bump-macosx-deployment-target-10-14 branch March 22, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Bump MACOSX_DEPLOYMENT_TARGET to Flutter minimum (10.14)
2 participants