Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(all): Update Google Java Format tool #2674

Merged
merged 5 commits into from
Mar 12, 2024
Merged

ci(all): Update Google Java Format tool #2674

merged 5 commits into from
Mar 12, 2024

Conversation

vbuberen
Copy link
Collaborator

Description

Just found out that we had version 1.3 of Google Java Format tool, which was released in 2017. Updated to the latest one.
Probably, some new issues would appear with formatting as I expect rules changes during all these years.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@vbuberen vbuberen force-pushed the update/java_format branch from 24529ef to 7823042 Compare March 11, 2024 15:24
@vbuberen
Copy link
Collaborator Author

Fixed formatting issues which appeared from this update.

Also, had to bump Gradle version in example app of Android Alarm Manager because of using Android Gradle Plugin 8.3.0. It aligns with version compatibility table here: https://developer.android.com/build/releases/gradle-plugin#updating-gradle but something that I will try to not forget to mention in changelogs when it comes to release.
Screenshot 2024-03-12 at 14 18 49

@miquelbeltran FYI ☝🏻

@vbuberen vbuberen merged commit 85b4423 into main Mar 12, 2024
25 of 27 checks passed
@vbuberen vbuberen deleted the update/java_format branch March 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants