Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects some more typos. #1028

Closed
wants to merge 19 commits into from
Closed

Corrects some more typos. #1028

wants to merge 19 commits into from

Conversation

dupgit
Copy link
Contributor

@dupgit dupgit commented Apr 18, 2023

Some more commits to correct typos. supposedly is corrected also here (#1027) and typos corrected by (#1021) were removed.

@chu11
Copy link
Member

chu11 commented Apr 18, 2023

hi @dupgit thanks for the fixes. However, I think most of these were intentionally skipped in prior PRs. The typos come from code we copied in from other projects, so we are working to get the typos fixed in those projects, and then we can bring them in via an update to that code. See #1026.

I think the remaining one you found is handled in #1027 and the strstr typo is a false positive.

@dupgit
Copy link
Contributor Author

dupgit commented Apr 18, 2023

Hi @chu11,

hi @dupgit thanks for the fixes. However, I think most of these were intentionally skipped in prior PRs. The typos come from code we copied in from other projects, so we are working to get the typos fixed in those projects, and then we can bring them in via an update to that code. See #1026.

Thanks for your answer and having taken the time to look at this PR.

I think the remaining one you found is handled in #1027 and the strstr typo is a false positive.

Ok. Sorry for that I didn't realized that there are some vendor products in the project and strstr escaped my screening. I close this PR.

Regards.

@dupgit dupgit closed this Apr 18, 2023
@jameshcorbett jameshcorbett mentioned this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants