fix: improve the clipboard pasting of files for better compatibility #1281
+63
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility use `read_future(&["text/uri-list") ...` instead of `read_text_future` when pasting files. This will make it work on the next gtk stable release (4.18) on mac os
flxzt
reviewed
Nov 21, 2024
| gio::File::for_path(&file_path), | ||
| target_pos, | ||
| true, | ||
| match appwindow |
There was a problem hiding this comment.
This is a candidate for DRY - almost the same code is used in three places in this source file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
read_future(&["text/uri-list") ...instead ofread_text_futurewhen pasting files from the clipboard.This will make it work on the next gtk stable release (4.18) on mac os.
Testing on https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7850 which fixes clipboard support on mac os for gtk.
As this shouldn't break things for the current gtk version we're currently using on the different os, I'm pushing this now.
Overall, a net positive