Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC-41616] overlay: add patchelf-venv #1165

Draft
wants to merge 1 commit into
base: fc-24.05-dev
Choose a base branch
from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 13, 2024

This patch adds a --add-rpath-and-shrink option which performs --add-rpath and --shrink-rpath in a single write to not leak space (--add-rpath increases the ELF header size, --shrink-rpath doesn't reduce it when necessary).

See also flyingcircusio/batou_ext#199 & FC-41616.

@flyingcircusio/release-managers

Note: this is a draft until I know whether this has a chance of getting upstreamed. Would still be interested in your opinion on the change itself and the patch in https://github.com/flyingcircusio/patchelf/commit/6ffde887d77275323c81c2e091891251b021abb3.patch

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

FC-41616

This patch adds a `--add-rpath-and-shrink` option which performs
`--add-rpath` and `--shrink-rpath` in a single write to not leak space
(`--add-rpath` increases the ELF header size, `--shrink-rpath` doesn't
reduce it when necessary).

See also flyingcircusio/batou_ext#199 &
FC-41616.
@Ma27
Copy link
Member Author

Ma27 commented Nov 14, 2024

OK no idea how to delete the just a test thingy here, I tried to submit a request against GitHub to make sure the token is still correct while investigating PL-133144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant