Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fc.agent maintenance reboots: warm -> cold is not significant #1209

Open
wants to merge 1 commit into
base: fc-24.05-dev
Choose a base branch
from

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Dec 21, 2024

@ctheune and I have decided that there is no good reason for making the change of a warm to a cold reboot trigger a reschedule and customer notification.

PL-133301

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • reduce postponing of scheduled maintenances when not necessary
    • no need to notify customers due to implementation specifics (warm and cold reboot have the same apparent consequences for customers)
  • Security requirements tested? (EVIDENCE)
    • adjusted unit test
    • automated tests still pass

@ctheune and I have decided that there is no good reason for making the
change of a warm to a cold reboot trigger a reschedule and customer
notification.

PL-133301
@osnyx osnyx marked this pull request as ready for review December 21, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant