-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Pre-emptively decode binary literals #889
Conversation
This reverts commit d1dc889.
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #889 +/- ##
==========================================
- Coverage 54.76% 54.62% -0.15%
==========================================
Files 584 585 +1
Lines 15291 15316 +25
Branches 2798 2801 +3
==========================================
- Hits 8374 8366 -8
- Misses 6917 6950 +33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 1.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
TL;DR
Decodes msgpack structs and turns them into flyte literals
TEST
ADMIN_API_URL=https://dogfood.cloud-staging.union.ai BASE_HREF=https://dogfood.cloud-staging.union.ai yarn start
Type
Are all requirements met?
Complete description
Decodes msgpack structs and turns them into flyte literals
Tracking Issue
Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/