Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pre-emptively decode binary literals #889

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

ursucarina
Copy link
Contributor

TL;DR

Decodes msgpack structs and turns them into flyte literals

image image

TEST

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Decodes msgpack structs and turns them into flyte literals

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

@ursucarina ursucarina changed the title fix: Pre-emptively decode binary literals feat: Pre-emptively decode binary literals Nov 11, 2024
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina enabled auto-merge (squash) November 11, 2024 21:09
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 59 lines in your changes missing coverage. Please review.

Project coverage is 54.62%. Comparing base (d1dc889) to head (e84fa44).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...es/oss-console/src/common/decodeMsgPackLiterals.ts 0.00% 35 Missing ⚠️
...ges/oss-console/src/components/Literals/helpers.ts 72.97% 20 Missing ⚠️
...s/Executions/ExecutionDetails/ExecutionNodeURL.tsx 0.00% 2 Missing ⚠️
packages/oss-console/src/App/index.tsx 0.00% 1 Missing ⚠️
.../Executions/ExecutionDetails/ExecutionMetadata.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #889      +/-   ##
==========================================
- Coverage   54.76%   54.62%   -0.15%     
==========================================
  Files         584      585       +1     
  Lines       15291    15316      +25     
  Branches     2798     2801       +3     
==========================================
- Hits         8374     8366       -8     
- Misses       6917     6950      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FrankFlitton FrankFlitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ursucarina ursucarina merged commit 17ef806 into master Nov 12, 2024
8 of 12 checks passed
@ursucarina ursucarina deleted the carina/msgpack branch November 12, 2024 19:14
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants