Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Separate remote signal functions #2933

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mao3267
Copy link
Contributor

@mao3267 mao3267 commented Nov 15, 2024

Tracking issue

Closes flyteorg/flyte#3459

Why are the changes needed?

Currently, the set_signal function can be used to handle three distinct actions: approving, rejecting, and providing input for gates. However, this implementation is not intuitive for users. To enhance clarity and usability, we propose splitting the set_signal function into three separate functions: approve, reject, and set_input. This change will make the functionality more straightforward and user-friendly during coding.

What changes were proposed in this pull request?

  1. Added three functions in FlyteRemote, which are approve, reject, and set_input, providing certain signals or values for gates.
  2. Do integration tests to make sure it works.

How was this patch tested?

  1. Integration tests are added.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.33%. Comparing base (3f0ab84) to head (6bda0f8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/remote/remote.py 15.00% 17 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2933       +/-   ##
===========================================
- Coverage   76.33%   38.33%   -38.01%     
===========================================
  Files         199      199               
  Lines       20840    20873       +33     
  Branches     2681     2685        +4     
===========================================
- Hits        15908     8001     -7907     
- Misses       4214    12659     +8445     
+ Partials      718      213      -505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[Core feature] add more intuitive methods to FlyteRemote class for gate nodes
1 participant