Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-639: Current day warnings widget #737

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

stembitf
Copy link
Collaborator

@stembitf stembitf commented Dec 18, 2024

Layout is according to Figma design here.

I tried a different layout similar as in Pekka's Android layout changes.
But it did not look OK yet.

…gs-widget

# Conflicts:
#	android/app/src/main/java/fi/fmi/mobileweather/BaseWidgetProvider.java
#	android/app/src/main/java/fi/fmi/mobileweather/LargeForecastWidgetProvider.java
#	android/app/src/main/java/fi/fmi/mobileweather/MaxForecastWidgetProvider.java
#	android/app/src/main/res/values-en/strings.xml
#	android/app/src/main/res/values-fi/strings.xml
#	android/app/src/main/res/values-sv/strings.xml
#	android/app/src/main/res/values/strings.xml
@stembitf stembitf self-assigned this Dec 18, 2024
Copy link
Collaborator

@geosaaga geosaaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These issues could be fixed if you have time. The same warning is repeated multiple times (should show wind warning or traffic warning only once).

And when only one warning then it should show time period when warning is valid.

Wind warning for sea areas (Utö) is missing wind direction and wind speed also. Should be displayed same way like here

https://www.ilmatieteenlaitos.fi/varoitukset

Näyttökuva 2024-12-19 kello 9 29 42

@stembitf
Copy link
Collaborator Author

stembitf commented Dec 19, 2024

The widget now displays all warnings it receives from https://weather-app-warnings-backend-prod.out.ocp.fmi.fi/v1/warnings?...

These are warnings of current day and of next few days.

Should the wind direction and speed be displayed like this in the widget?:
Screenshot 2024-12-19 at 11 22 48

Should that be shown instead of the standard wind warning icon?

No extra text needed?

These issues could be fixed if you have time. The same warning is repeated multiple times (should show wind warning or traffic warning only once).

And when only one warning then it should show time period when warning is valid.

Wind warning for sea areas (Utö) is missing wind direction and wind speed also. Should be displayed same way like here

https://www.ilmatieteenlaitos.fi/varoitukset

Näyttökuva 2024-12-19 kello 9 29 42

@geosaaga
Copy link
Collaborator

You should show only current day warnings in this widget, not next few days. 5 day warnings will be implemented later.

Yes, replace standard wind warning icon with that icon (wind arrow and wind speed as number).

@stembitf
Copy link
Collaborator Author

OK

You should show only current day warnings in this widget, not next few days. 5 day warnings will be implemented later.

Yes, replace standard wind warning icon with that icon (wind arrow and wind speed as number).

@stembitf
Copy link
Collaborator Author

Requested changes done.
But @geosaaga could still test it before merge.

@geosaaga
Copy link
Collaborator

Yes, I will continue from here. Thanks!

@stembitf
Copy link
Collaborator Author

I just tried to merge android-main into this branch.
The merge conflicts do not look bad fortunately.

But I did not finish the merge - just in case.

@geosaaga geosaaga changed the base branch from android-main to main December 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants