-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue-639: Current day warnings widget #737
base: main
Are you sure you want to change the base?
Conversation
…gs-widget # Conflicts: # android/app/src/main/java/fi/fmi/mobileweather/BaseWidgetProvider.java # android/app/src/main/java/fi/fmi/mobileweather/LargeForecastWidgetProvider.java # android/app/src/main/java/fi/fmi/mobileweather/MaxForecastWidgetProvider.java # android/app/src/main/res/values-en/strings.xml # android/app/src/main/res/values-fi/strings.xml # android/app/src/main/res/values-sv/strings.xml # android/app/src/main/res/values/strings.xml
… renaming in other classes.
…lls." This reverts commit ad56c8c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These issues could be fixed if you have time. The same warning is repeated multiple times (should show wind warning or traffic warning only once).
And when only one warning then it should show time period when warning is valid.
Wind warning for sea areas (Utö) is missing wind direction and wind speed also. Should be displayed same way like here
https://www.ilmatieteenlaitos.fi/varoitukset
The widget now displays all warnings it receives from https://weather-app-warnings-backend-prod.out.ocp.fmi.fi/v1/warnings?... These are warnings of current day and of next few days. Should the wind direction and speed be displayed like this in the widget?: Should that be shown instead of the standard wind warning icon? No extra text needed?
|
You should show only current day warnings in this widget, not next few days. 5 day warnings will be implemented later. Yes, replace standard wind warning icon with that icon (wind arrow and wind speed as number). |
OK
|
Requested changes done. |
Yes, I will continue from here. Thanks! |
I just tried to merge android-main into this branch. But I did not finish the merge - just in case. |
Layout is according to Figma design here.
I tried a different layout similar as in Pekka's Android layout changes.
But it did not look OK yet.