[FEAT] Identify client by cpf #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deboracosilveira
commented
May 20, 2024
deboracosilveira
commented
- Identify client by cpf
- Move tests to /tests
- Refactor get exceptions
- Refactor dockerfile and docker-compose
| @@ -9,11 +9,35 @@ export class ClientReaderService implements ClientReaderServicePort { | |||
|
|
|||
| async findById(id: string): Promise<Client> { | |||
| try { | |||
| return this.clientRepository.findById(id); | |||
There was a problem hiding this comment.
Exceptions não estavam funcionando e not found estava dando 200
fmo00
reviewed
May 20, 2024
fmo00
approved these changes
May 20, 2024
deboracosilveira
force-pushed
the
identify-client-by-cpf
branch
from
8428b14
to
8144a30
Compare
eduardopetri
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.