[MODDATAIMP-942] [Orchid] Add missing permissions #310
Conversation
ncovercash
changed the base branch from
master
to
release/2023_R1_v2.7.0_Orchid
| @@ -68,8 +68,6 @@ invoice-storage.invoices.item.put | |||
| invoice-storage.invoice-lines.item.post | |||
| invoice-storage.invoice-lines.item.put | |||
| invoice-storage.invoice-lines.collection.get | |||
| acquisitions-units.units.collection.get | |||
| acquisitions-units.memberships.collection.get | |||
There was a problem hiding this comment.
Duplicated elsewhere in the file
| "instance-authority-links.instances.collection.put", | ||
| "user-tenants.collection.get", | ||
| "organizations.organizations.collection.get", | ||
| "invoices.acquisitions-units-assignments.assign", |
There was a problem hiding this comment.
as far as I know, we should not add this permission here, since this permission is optional and a user assigned to a particular acquisition unit should be provided with it. If this permission is added here, the user who is not supposed to be provided with this permission will receive it.
It seems that "user-tenants.collection.get" permission is required for consortium-related functionalities (ECS) that have been introduced only in Poppy, so this permission should not be added for the Orchid release.
There was a problem hiding this comment.
please, remove "user-tenants.collection.get" permission here as well since it is needed by consortium-related functionality that is not present in Orchid release
|
Kudos, SonarCloud Quality Gate passed!
|
|
See #312 |
Jira MODDATAIMP-942
Orchid version of #309
Purpose
A couple straggling permissions needed to be added for full DI functionality: