Add OpenAccess Entity types to FQM / Lists App #277
Conversation
|
|
n-bux
changed the title
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.4.xsd"> | ||
|
|
||
| <changeSet id="create_view_publication_request" author="your_author_name_here"> |
There was a problem hiding this comment.
Super small thing, but
| <changeSet id="create_view_publication_request" author="your_author_name_here"> | |
| <changeSet id="create_view_publication_request" author="[email protected]"> |
There was a problem hiding this comment.
Yes, I wasn't sure which address to use yet.. my student mail won't be accessible after graduation.. I will add one!
| id: '0f8f6d6f-504f-4aa9-9d98-9779aaaa907b', | ||
| name: 'drv_openaccess_party', | ||
| private: false, | ||
| fromClause: 'src_oa_party AS party\nLEFT JOIN src_oa_alternate_email_address ON alternate_email_address.aea_owner_fk=party.p_id\nLEFT JOIN src_oa_refdata_value AS p_institution_level_1 ON p_institution_level_1.rdv_id=party.p_institution_level_1_fk', |
There was a problem hiding this comment.
Since this is JSON5, you can add line breaks to make this more readable
| fromClause: 'src_oa_party AS party\nLEFT JOIN src_oa_alternate_email_address ON alternate_email_address.aea_owner_fk=party.p_id\nLEFT JOIN src_oa_refdata_value AS p_institution_level_1 ON p_institution_level_1.rdv_id=party.p_institution_level_1_fk', | |
| fromClause: 'src_oa_party AS party \ | |
| LEFT JOIN src_oa_alternate_email_address ON alternate_email_address.aea_owner_fk=party.p_id \ | |
| LEFT JOIN src_oa_refdata_value AS p_institution_level_1 ON p_institution_level_1.rdv_id=party.p_institution_level_1_fk', |
There was a problem hiding this comment.
I entered line break in the entity type creator, and it changed it to "\n" automatically..
when I tried changing this to line breaks in the source file, it didn't work (I used line breaks plus indentation, maybe that doesn't work?)
but for me no big deal here..
| { | ||
| name: 'party_id', | ||
| dataType: { | ||
| dataType: 'openUUIDType', | ||
| }, | ||
| queryable: true, | ||
| visibleByDefault: true, | ||
| valueGetter: 'party.p_id', | ||
| }, |
There was a problem hiding this comment.
I believe at least 1 column needs isIdColumn: true (something like that... I might have the property name wrong).
There was a problem hiding this comment.
I think I did tick the box in entity type creator, but it wasn't written to the file.. I did it manually now..
There was a problem hiding this comment.
Problem was: entity type creator has got a bug, the checkbox in the UI is mislinked to visibleByDefault
| id: '0f8f6d6f-504f-4aa9-9d98-9779aaaa907b', | ||
| name: 'drv_openaccess_party', | ||
| private: false, | ||
| fromClause: 'src_oa_party AS party\nLEFT JOIN src_oa_alternate_email_address ON alternate_email_address.aea_owner_fk=party.p_id\nLEFT JOIN src_oa_refdata_value AS p_institution_level_1 ON p_institution_level_1.rdv_id=party.p_institution_level_1_fk', |
There was a problem hiding this comment.
It doesn't look like src_oa_alternate_email_address or src_oa_refdata_value are actually used, so this could just be
| fromClause: 'src_oa_party AS party\nLEFT JOIN src_oa_alternate_email_address ON alternate_email_address.aea_owner_fk=party.p_id\nLEFT JOIN src_oa_refdata_value AS p_institution_level_1 ON p_institution_level_1.rdv_id=party.p_institution_level_1_fk', | |
| fromClause: 'src_oa_party AS party', |
There was a problem hiding this comment.
they will be used for more columns, I just wanted to start testing with a few columns only
src/main/resources/db/changelog/changes/v2.1.1/harvested-views.xml
Outdated
Show resolved
Hide resolved
…ll correction in FROM clause if new entity type after this change, querying from "entity type creator" tool works
|
Purpose
Add relevant views from the OpenAccess module (as identified by the Reporting SIG in the Wiki) as new entity types to FQM Manager in order to make them available in "Lists" app
Approach
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.
Pre-Merge Checklist
If you are adding entity type(s), have you:
src/main/resources/entity-typesdirectory?/entity-types/{id}works as expected?GET /entity-types/{id}does not havemod-fqm-manager.entityType.in the response)