MODFQMMGR-311 Fix instance stat codes #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweaver-ebsco
force-pushed
the
MODFQMMGR-311-stat-codes
branch
from
adad14c to
45b98f2
Compare
bvsharp
approved these changes
Aug 2, 2024
kjain110
approved these changes
Aug 2, 2024
mweaver-ebsco
force-pushed
the
MODFQMMGR-311-stat-codes
branch
2 times, most recently
from
ada6742 to
ada2ed8
Compare
This commit fixes several small issues with instance statistical codes
- The incorrect jsonb_array_elements() was used
- The entity type containing stat code names had no ID field. This was
causing a NullPointerException in the ResultSetRepository when
retrieving column values for stat codes in simple_instance
- The stat codes field was not marked as queryable (this was
because we previously marked all array-type fields as non-queryable.
We'll be making them queryable again as we fix them)
- The translation on the stat codes field was incorrect (it was
"Statistical code names" which is misleading when there's a
"Statistical code name" displayed in the Inventory app which isn't the
same field
- For now, we'll go with "Statistical code" in order to match the
Inventory app (this is based on feedback from BELA, so we'll go
ahead and violate our translation guidelines this time)
- The field was marked as visibleByDefault, which is incorrect
MODFQMMGR-311 Mark the stat code full ID column as an ID
This entity type not having any ID columns causes a NullPointerException
in the ResultSetRepository when retrieving column values for
statistical code names in simple_instance
MODFQMMGR-311 Make statistical code names queryable
bla
mweaver-ebsco
force-pushed
the
MODFQMMGR-311-stat-codes
branch
from
ada2ed8 to
ada3c0f
Compare
mweaver-ebsco
commented
Aug 2, 2024
| @@ -491,7 +491,7 @@ | |||
| "entityType.simple_item_details.permanent_location_id": "Permanent location UUID", | |||
| "entityType.simple_item_details.purchase_order_line_identifier": "Purchase order line identifier", | |||
| "entityType.simple_item_details.statistical_code_ids": "Statistical code UUIDs", | |||
| "entityType.simple_item_details.statistical_code_names": "Statistical code names", | |||
There was a problem hiding this comment.
This violates our translation guidelines, but our POs talked it over and ran it by the BELA working group, and they landed on making it singular to keep the name consistent, since it's always singular in quite a few places, and only plural in the DB field name that users never actually see
mweaver-ebsco
force-pushed
the
MODFQMMGR-311-stat-codes
branch
from
ada3c0f to
adaa0e1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the purpose of the pull request. Include background information if necessary.
Approach
How does this change fulfill the purpose?
TODOS and Open Questions
Learning
Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.
Pre-Merge Checklist
If you are adding entity type(s), have you:
src/main/resources/entity-typesdirectory?/entity-types/{id}works as expected?GET /entity-types/{id}does not havemod-fqm-manager.entityType.in the response)If you are changing/removing entity type(s), have you: