Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODFQMMGR-496 Create a unique permission for each endpoint to retrieve content and group them within a permission set. #448

Conversation

vgema
Copy link
Contributor

@vgema vgema commented Oct 4, 2024

Create a unique permission for each endpoint to retrieve content and group them within a permission set.

Purpose

Describe the purpose of the pull request. Include background information if necessary.

Approach

How does this change fulfill the purpose?

TODOS and Open Questions

  • Use GitHub checklists. When solved, check the box and explain the answer.

Learning

Describe the research stage. Add links to blog posts, patterns, libraries or addons used to solve this problem.

Pre-Merge Checklist

If you are adding entity type(s), have you:

  • Added the JSON5 definition to the src/main/resources/entity-types directory?
  • Ensured that GETing the entity type at /entity-types/{id} works as expected?
  • Added translations for all fields, per the translation guidelines? (Check this by ensuring GET /entity-types/{id} does not have mod-fqm-manager.entityType. in the response)
  • Added views to liquibase, as applicable?
  • Added required interfaces to the module descriptor?
  • Checked that querying fields works correctly and all SQL is valid?

If you are changing/removing entity type(s), have you:

  • Added migration code for any changes?

Create a unique permission for each endpoint to retrieve content and group them within a permission set.
@vgema vgema requested review from bvsharp and mweaver-ebsco October 4, 2024 14:35
@vgema vgema self-assigned this Oct 4, 2024
{
"permissionName": "fqm.query.async.results.post",
"displayName": "FQM - Retrieve results of a submitted query",
"description": "Retrieve results of a submitted query",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description feels wrong. Maybe something like this?

Suggested change
"description": "Retrieve results of a submitted query",
"description": "Submit an a query to run asynchronously",

…protects-more-than-one-endpoint

# Conflicts:
#	descriptors/ModuleDescriptor-template.json
Copy link

sonarcloud bot commented Oct 23, 2024

@vgema vgema merged commit 9089709 into master Oct 23, 2024
5 of 6 checks passed
@vgema vgema deleted the MODFQMMGR-496-fqm-query-async-results-get-protects-more-than-one-endpoint branch October 23, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants