MODINREACH-443 The custom field type is not catering for a list value in inn-reach code.

[SreejaMangarapu]

Purpose

https://folio-org.atlassian.net/browse/MODINREACH-443

Approach

If the user record have any of the custom field value with non-string type, then with help of custom deserialization class we are ignoring the non-string values in custom fields

TODOS and Open Questions

• Check logging

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

• Does this PR meet or exceed the expected quality standards?
  • Code coverage on new code is 80% or greater
  • Duplications on new code is 3% or less
  • There are no major code smells or security issues
• Does this introduce breaking changes?
  • Were any API paths or methods changed, added or removed?
  • Were there any schema changes?
  • Did any of the interface versions change?
  • Were permissions changed, added, or removed?
  • Are there new interface dependencies?
  • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

• What other modules will these changes impact?
• Do JIRAs exist to update the impacted modules?
  • If not, please create them
  • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
  • Do they have all they appropriate links to blocked/related issues?
• Are the JIRAs under active development?
  • If not, contact the project's PO and make sure they're aware of the urgency.
• Do PRs exist for these changes?
  • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[SreejaMangarapu]

In mod-inn-reach, User class is accepting custom fields as Map<String, String>, this error will occur only when any custom field of user contain non string value. To fix this issue we have added CustomFieldsDeserializer class, here with help of
if (valueNode.isTextual()) {customFields.put(key, valueNode.asText());}} we are ignoring all the non-string values.