Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODINVSTOR-1270] Allow Subject sources and Subject type to have consortium source #1098

Merged
merged 7 commits into from
Oct 21, 2024
Merged

[MODINVSTOR-1270] Allow Subject sources and Subject type to have consortium source #1098

merged 7 commits into from
Oct 21, 2024

Conversation

RomanChernetskyi
Copy link
Contributor

@RomanChernetskyi RomanChernetskyi commented Oct 15, 2024 •
edited
Loading

Purpose

Allow Subject sources and Subject type to have consortium source

Approach

Added new source type 'consortium' for Subject sources and Subject type
Added following validation:

  • Creating or Updating entity with source folio not allowed
  • User can create subject source and subject type with source 'consortium' only at ECS setup
  • User can update source (consortium or local) only at ECS env

Jira

https://folio-org.atlassian.net/browse/MODINVSTOR-1270

@RomanChernetskyi RomanChernetskyi requested a review from a team as a code owner October 15, 2024 13:31
psmagin
psmagin requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@psmagin psmagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please cover it with unit tests.

src/main/java/org/folio/rest/support/SubjectUtil.java Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@RomanChernetskyi RomanChernetskyi merged commit ed2dd41 into master Oct 21, 2024
6 checks passed
@RomanChernetskyi RomanChernetskyi deleted the MODINVSTOR-1270 branch October 21, 2024 14:10
@SerhiiNosko SerhiiNosko mentioned this pull request Oct 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukhiddin-yusuf mukhiddin-yusuf mukhiddin-yusuf approved these changes

@RuslanLavrov RuslanLavrov RuslanLavrov approved these changes

@KaterynaSenchenko KaterynaSenchenko KaterynaSenchenko approved these changes

@psmagin psmagin psmagin approved these changes

@viacheslavkol viacheslavkol Awaiting requested review from viacheslavkol viacheslavkol is a code owner automatically assigned from folio-org/spitfire-backend

@SvitlanaKovalova1 SvitlanaKovalova1 Awaiting requested review from SvitlanaKovalova1 SvitlanaKovalova1 is a code owner automatically assigned from folio-org/spitfire-backend

@Aliaksandr-Fedasiuk Aliaksandr-Fedasiuk Awaiting requested review from Aliaksandr-Fedasiuk

@dmytrokrutii dmytrokrutii Awaiting requested review from dmytrokrutii

@VRohach VRohach Awaiting requested review from VRohach

@JavokhirAbdullayev JavokhirAbdullayev Awaiting requested review from JavokhirAbdullayev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RomanChernetskyi @psmagin @KaterynaSenchenko @RuslanLavrov @mukhiddin-yusuf