Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publishing-events): change Kafka event publishing keys for holdings and items. #1108

Merged
merged 8 commits into from
Nov 5, 2024

Conversation

SvitlanaKovalova1
Copy link
Contributor

Purpose

MODINVSTOR-1281 Currently, mod-search has an issue with processing events received from the mod-inventory-storage after creating a list of holdings for one Instance via the POST /holdings-storage/batch/synchronous endpoint.
The mod-inventory-storage publishes the list of events on creating holdings for an instance with the instanceId publishing key. So the list of events with the same instanceId publishing key are published.

The mod-search consumes events, groups them by key and processes only the one event, so in this case the rest events with the same instanceId key will not be processed and the data will not get into the holding table of the mod-search module.
The same issue with Items : POST /item-storage/batch/synchronous endpoint.
In order to avoid this issue, need to change the key for publishing events for holdings and items.

Approach

Kafka event publishing keys have been changed:

  • for holdings with instanceId to holdingId;
  • for items with instanceId to itemId.

Changes Checklist

  • API Changes: Document any API paths, methods, request or response bodies changed, added, or removed.
  • Database Schema Changes: Indicate any database schema changes and their impact. Confirm that migration scripts were created.
  • Interface Version Changes: Indicate any changes to interface versions.
  • Interface Dependencies: Document added or removed dependencies.
  • Permissions: Document any changes to permissions.
  • Logging: Confirm that logging is appropriately handled.
  • Unit Testing: Confirm that changed classes were covered by unit tests.
  • Integration Testing: Confirm that changed logic was covered by integration tests.
  • Manual Testing: Confirm that changes were tested on local or dev environment.
  • NEWS: Confirm that the NEWS file is updated with relevant information about the changes made in this pull request.

@SvitlanaKovalova1 SvitlanaKovalova1 marked this pull request as ready for review November 1, 2024 17:27
@SvitlanaKovalova1 SvitlanaKovalova1 requested a review from a team as a code owner November 1, 2024 17:27
Copy link

sonarcloud bot commented Nov 5, 2024

@SvitlanaKovalova1 SvitlanaKovalova1 merged commit 0dbe3be into master Nov 5, 2024
6 checks passed
@SvitlanaKovalova1 SvitlanaKovalova1 deleted the MODINVSTOR-1281 branch November 5, 2024 15:37
psmagin pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants